Issue #1234 - Rework strings in debug facility

src/plugin/Plugin.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 100 matching lines @@
   return _Module.UnregisterServer(TRUE);
 }
 
 void InitPlugin(bool isInstall)
 {
   CPluginSettings* settings = CPluginSettings::GetInstance();
 
   if (isInstall)
   {
     DEBUG_GENERAL(
-      L"================================================================================\nINSTALLER " +
-      CString(IEPLUGIN_VERSION) +
-      L"\n================================================================================")
+      L"================================================================================\n"
+      L"INSTALLER " IEPLUGIN_VERSION L"\n"
+      L"================================================================================")
   }
   else
   {
     DEBUG_GENERAL(
-      L"================================================================================\nUPDATER " +
-      CString(IEPLUGIN_VERSION) +
-      L"\n================================================================================")
+      L"================================================================================\n"
+      L"UPDATER " IEPLUGIN_VERSION L"\n"
+      L"================================================================================")
   }
 
   // Post async plugin error
   CPluginError pluginError;
   while (CPluginClientBase::PopFirstPluginError(pluginError))
   {
     CPluginClientBase::LogPluginError(pluginError.GetErrorCode(), pluginError.GetErrorId(), pluginError.GetErrorSubid(), pluginError.GetErrorDescription(), true, pluginError.GetProcessId(), pluginError.GetThreadId());
   }
 }
 
 // Called from installer
 EXTERN_C void STDAPICALLTYPE OnInstall(MSIHANDLE hInstall, MSIHANDLE tmp)
 {
   InitPlugin(true);
 }
 
 // Called from updater
 EXTERN_C void STDAPICALLTYPE OnUpdate(void)
 {
   InitPlugin(false);
 }