Issue #1234 - Rework strings in debug facility

src/plugin/PluginClientBase.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 66 matching lines @@
      * When the code has a systematic way of handling bad_alloc, we'll rethrow (probably).
      * Until then, we mask the exception and make no modification.
      */
   }
   catch(...)
   {
     // no modification if any other exception
   }
 }
 
-void CPluginClientBase::LogPluginError(DWORD errorCode, int errorId, int errorSubid, const CString& description, bool isAsync, DWORD dwProcessId, DWORD dwThreadId)
+void CPluginClientBase::LogPluginError(DWORD errorCode, int errorId, int errorSubid, const std::string& description, bool isAsync, DWORD dwProcessId, DWORD dwThreadId)
 {
   // Prevent circular references
   if (CPluginSettings::HasInstance() && isAsync)
   {
     DEBUG_ERROR_CODE_EX(errorCode, description, dwProcessId, dwThreadId);
 
     CString pluginError;
     pluginError.Format(L"%2.2d%2.2d", errorId, errorSubid);
 
     CString pluginErrorCode;
     pluginErrorCode.Format(L"%u", errorCode);
 
     CPluginSettings* settings = CPluginSettings::GetInstance();
 
     settings->AddError(pluginError, pluginErrorCode);
   }
 
   // Post error to client for later submittal
   if (!isAsync)
   {
     CPluginClientBase::PostPluginError(errorId, errorSubid, errorCode, description);
   }
 }
 
 
-void CPluginClientBase::PostPluginError(int errorId, int errorSubid, DWORD errorCode, const CString& errorDescription)
+void CPluginClientBase::PostPluginError(int errorId, int errorSubid, DWORD errorCode, const std::string& errorDescription)
 {
   s_criticalSectionLocal.Lock();
   {
     CPluginError pluginError(errorId, errorSubid, errorCode, errorDescription);
 
     s_pluginErrors.push_back(pluginError);
   }
   s_criticalSectionLocal.Unlock();
 }
 
@@ skipping 11 matching lines @@
 
       hasError = true;
 
       s_pluginErrors.erase(it);
     }
   }
   s_criticalSectionLocal.Unlock();
 
   return hasError;
 }