src/plugin/PluginClientBase.cpp - Issue 5747779603267584: Issue #1234 - Rework strings in debug facility

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/plugin/PluginClientBase.cpp

Issue 5747779603267584: Issue #1234 - Rework strings in debug facility (Closed)

Patch Set: rebase Created March 3, 2015, 8:03 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/plugin/PluginClientBase.cpp

===================================================================

--- a/src/plugin/PluginClientBase.cpp

+++ b/src/plugin/PluginClientBase.cpp

@@ -57,7 +57,7 @@

}

-void LogQueue::LogPluginError(DWORD errorCode, int errorId, int errorSubid, const CString& description, bool isAsync, DWORD dwProcessId, DWORD dwThreadId)

+void LogQueue::LogPluginError(DWORD errorCode, int errorId, int errorSubid, const std::string& description, bool isAsync, DWORD dwProcessId, DWORD dwThreadId)

{

// Prevent circular references

if (CPluginSettings::HasInstance() && isAsync)

@@ -83,7 +83,7 @@

}

-void LogQueue::PostPluginError(int errorId, int errorSubid, DWORD errorCode, const CString& errorDescription)

+void LogQueue::PostPluginError(int errorId, int errorSubid, DWORD errorCode, const std::string& errorDescription)

{

s_criticalSectionQueue.Lock();

{

« no previous file with comments | « src/plugin/PluginClientBase.h ('k') | src/plugin/PluginDebug.h » ('j') | src/plugin/PluginDebug.cpp » ('J')