Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(123)

Issue 5749479856668672: issue #764 - Adblock Warning opt in message isn't triggered (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 7 months ago by saroyanm
Modified:
5 years, 7 months ago
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Related ticket: https://issues.adblockplus.org/ticket/764

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M lib/ui.js View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5
saroyanm
Wladimir can you please have a look, Should be a quick one.
5 years, 7 months ago (2014-07-09 18:43:09 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/5749479856668672/diff/5629499534213120/lib/ui.js File lib/ui.js (right): http://codereview.adblockplus.org/5749479856668672/diff/5629499534213120/lib/ui.js#newcode1890 lib/ui.js:1890: if ("links" in notification) How about |if (notification.links)| just ...
5 years, 7 months ago (2014-07-09 18:51:46 UTC) #2
saroyanm
http://codereview.adblockplus.org/5749479856668672/diff/5629499534213120/lib/ui.js File lib/ui.js (right): http://codereview.adblockplus.org/5749479856668672/diff/5629499534213120/lib/ui.js#newcode1890 lib/ui.js:1890: if ("links" in notification) On 2014/07/09 18:51:46, Wladimir Palant ...
5 years, 7 months ago (2014-07-09 18:57:25 UTC) #3
saroyanm
Updated.
5 years, 7 months ago (2014-07-09 19:01:28 UTC) #4
Wladimir Palant
5 years, 7 months ago (2014-07-10 05:42:27 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5