Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(551)

Issue 5749582424178688: Ported over anti-adblock message notification (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 3 months ago by Thomas Greiner
Modified:
6 years, 2 months ago
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

This issue is a port of the Firefox implementation of the anti-adblock message notification (see http://codereview.adblockplus.org/5538776168267776/). It includes all bug fixes that were necessary for the notification system to work properly again (as discussed in http://codereview.adblockplus.org/6098518317989888/).

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -36 lines) Patch
M background.js View 1 2 9 chunks +58 lines, -22 lines 0 comments Download
M chrome/ext/background.js View 1 chunk +0 lines, -3 lines 0 comments Download
M iconAnimation.js View 2 chunks +6 lines, -6 lines 0 comments Download
M lib/prefs.js View 1 chunk +1 line, -0 lines 0 comments Download
M lib/utils.js View 1 1 chunk +4 lines, -1 line 0 comments Download
M metadata.common View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M notification.html View 3 chunks +8 lines, -0 lines 0 comments Download
M notification.js View 2 chunks +24 lines, -4 lines 0 comments Download
M webrequest.js View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Thomas Greiner
6 years, 3 months ago (2014-02-28 18:45:51 UTC) #1
Felix Dahlke
Sorry for the delay, here we go! Looks pretty good all in all, just two ...
6 years, 2 months ago (2014-03-18 14:21:41 UTC) #2
Thomas Greiner
http://codereview.adblockplus.org/5749582424178688/diff/5629499534213120/background.js File background.js (right): http://codereview.adblockplus.org/5749582424178688/diff/5629499534213120/background.js#newcode255 background.js:255: function initAntiAdblockNotification() On 2014/03/18 14:21:41, Felix H. Dahlke wrote: ...
6 years, 2 months ago (2014-03-19 13:45:40 UTC) #3
Felix Dahlke
6 years, 2 months ago (2014-03-21 13:55:37 UTC) #4
LGTM, sorry for the delays!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5