Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(954)

Issue 5754941108912128: Issue 455 - Find function in Filter Preferences - No indication when keyword is not found (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 4 months ago by Wladimir Palant
Modified:
5 years, 4 months ago
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

In addition to fixing the issue, I also added one more method required by the find bar now (not implemented at this point) and made sure exceptions in one listener don`t prevent us from calling other listeners.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M chrome/content/ui/filters-search.js View 2 chunks +20 lines, -2 lines 0 comments Download

Messages

Total messages: 2
Wladimir Palant
5 years, 4 months ago (2014-07-15 11:35:59 UTC) #1
Thomas Greiner
5 years, 4 months ago (2014-07-15 12:24:49 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5