Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5766275812818944: Issue 2173 - Fixed: "Block element" dialog isn't moved to correct position when dragging (Closed)

Created:
March 19, 2015, 2:14 p.m. by Sebastian Noack
Modified:
March 20, 2015, 5:53 p.m.
Reviewers:
Thomas Greiner, kzar
CC:
Wladimir Palant
Visibility:
Public.

Description

Issue 2173 - Fixed: "Block element" dialog isn't moved to correct position when dragging

Patch Set 1 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -32 lines) Patch
M block.html View 1 chunk +4 lines, -1 line 0 comments Download
M block.js View 2 chunks +39 lines, -31 lines 3 comments Download

Messages

Total messages: 6
Sebastian Noack
March 19, 2015, 2:14 p.m. (2015-03-19 14:14:55 UTC) #1
kzar
Seems a little ugly but I can't see how else to do it, LGTM http://codereview.adblockplus.org/5766275812818944/diff/5741031244955648/block.js ...
March 19, 2015, 4:15 p.m. (2015-03-19 16:15:15 UTC) #2
Sebastian Noack
http://codereview.adblockplus.org/5766275812818944/diff/5741031244955648/block.js File block.js (right): http://codereview.adblockplus.org/5766275812818944/diff/5741031244955648/block.js#newcode97 block.js:97: var dragStartX; On 2015/03/19 16:15:15, kzar wrote: > Nit: ...
March 19, 2015, 4:52 p.m. (2015-03-19 16:52:14 UTC) #3
kzar
http://codereview.adblockplus.org/5766275812818944/diff/5741031244955648/block.js File block.js (right): http://codereview.adblockplus.org/5766275812818944/diff/5741031244955648/block.js#newcode97 block.js:97: var dragStartX; On 2015/03/19 16:52:14, Sebastian Noack wrote: > ...
March 19, 2015, 4:55 p.m. (2015-03-19 16:55:01 UTC) #4
Sebastian Noack
On 2015/03/19 16:55:01, kzar wrote: > http://codereview.adblockplus.org/5766275812818944/diff/5741031244955648/block.js > File block.js (right): > > http://codereview.adblockplus.org/5766275812818944/diff/5741031244955648/block.js#newcode97 > ...
March 19, 2015, 5:06 p.m. (2015-03-19 17:06:44 UTC) #5
Thomas Greiner
March 20, 2015, 11:57 a.m. (2015-03-20 11:57:00 UTC) #6
LGTM

Not a fan of user agent string checks myself but in this case the alternatives
would cause too much overhead with too little extra benefit, so it's fine with
me.

Powered by Google App Engine
This is Rietveld