metadata.common - Issue 5767063142400000: notification fixes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: metadata.common

Issue 5767063142400000: notification fixes (Closed)

Left Patch Set: removed import of ext/background.js from notification.html Created March 4, 2014, 4:19 p.m.

Right Patch Set: Nit fix for long lines Created March 6, 2014, 10:10 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Right: Side by side diff | Download

LEFT	RIGHT
(no file at all)
1 [general]	1 [general]

2 version = 1.7.4	2 version = 1.7.4

3 backgroundScripts = ext/common.js	3 backgroundScripts = ext/common.js

4 ext/background.js	4 ext/background.js

5 lib/compat.js	5 lib/compat.js

6 lib/info.js	6 lib/info.js

7 lib/io.js	7 lib/io.js

8 lib/adblockplus.js	8 lib/adblockplus.js

9 lib/punycode.js	9 lib/punycode.js

10 lib/publicSuffixList.js	10 lib/publicSuffixList.js

11 lib/basedomain.js	11 lib/basedomain.js

12 lib/sha1.js	12 lib/sha1.js

13 lib/jsbn.js	13 lib/jsbn.js

14 lib/rsa.js	14 lib/rsa.js

15 webrequest.js	15 webrequest.js

16 popupBlocker.js	16 popupBlocker.js

17 iconAnimation.js	17 iconAnimation.js

18 background.js	18 background.js

19 permissions = http:/// https:///	19 permissions = http:/// https:///

20	20

21 [contentScripts]	21 [contentScripts]

22 document_start = ext/common.js ext/content.js include.preload.js	22 document_start = ext/common.js ext/content.js include.preload.js

23 document_end = include.postload.js	23 document_end = include.postload.js

24	24

25 [mapping]	25 [mapping]

26 ext/common.js = chrome/ext/common.js	26 ext/common.js = chrome/ext/common.js

27 ext/background.js = chrome/ext/background.js	27 ext/background.js = chrome/ext/background.js

28 ext/content.js = chrome/ext/content.js	28 ext/content.js = chrome/ext/content.js

29 ext/popup.js = chrome/ext/popup.js	29 ext/popup.js = chrome/ext/popup.js

	30 notification.html = chrome/notification.html

30 subscriptions.xml = adblockplus/chrome/content/ui/subscriptions.xml	31 subscriptions.xml = adblockplus/chrome/content/ui/subscriptions.xml

31 firstRun.html = adblockplus/chrome/content/ui/firstRun.html	32 firstRun.html = adblockplus/chrome/content/ui/firstRun.html

32 firstRun.js = adblockplus/chrome/content/ui/firstRun.js	33 firstRun.js = adblockplus/chrome/content/ui/firstRun.js

33 i18n.js = adblockplus/chrome/content/ui/i18n.js	34 i18n.js = adblockplus/chrome/content/ui/i18n.js

34 skin/firstRun.css = adblockplus/chrome/skin/firstRun.css	35 skin/firstRun.css = adblockplus/chrome/skin/firstRun.css

35 skin/abp-icon-big.png = adblockplus/chrome/skin/abp-icon-big.png	36 skin/abp-icon-big.png = adblockplus/chrome/skin/abp-icon-big.png

36 skin/ajax-loader.gif = adblockplus/chrome/skin/ajax-loader.gif	37 skin/ajax-loader.gif = adblockplus/chrome/skin/ajax-loader.gif

37 skin/background.png = adblockplus/chrome/skin/background.png	38 skin/background.png = adblockplus/chrome/skin/background.png

38 skin/background-main.png = adblockplus/chrome/skin/background-main.png	39 skin/background-main.png = adblockplus/chrome/skin/background-main.png

39 skin/background-share.png = adblockplus/chrome/skin/background-share.png	40 skin/background-share.png = adblockplus/chrome/skin/background-share.png

(...skipping 56 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
96 addSubscription.label	97 addSubscription.label

97 addSubscriptionAdd.label	98 addSubscriptionAdd.label

98 addSubscriptionOther.label	99 addSubscriptionOther.label

99 acceptableAds2.label	100 acceptableAds2.label

100 viewList.label	101 viewList.label

101 readMore.label	102 readMore.label

102 adblockplus/chrome/locale/*/subscriptionSelection.dtd = location.label	103 adblockplus/chrome/locale/*/subscriptionSelection.dtd = location.label

103 title.label	104 title.label

104 adblockplus/chrome/locale/*/meta.properties = =name	105 adblockplus/chrome/locale/*/meta.properties = =name

105 adblockplus/chrome/locale//firstRun.properties = =	106 adblockplus/chrome/locale//firstRun.properties = =

LEFT	RIGHT