notification fixes

notification.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2013 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
+
+//This case is true only for chrome when loading from notification.html
+if (typeof ext === "undefined")
+{
+  var ext = chrome.extension.getBackgroundPage().ext;
+}
 
 var backgroundPage = ext.backgroundPage.getWindow();

[Thomas Greiner, 2014/03/05 13:24:47]

This can be changed to use the Chrome API.

[saroyanm, 2014/03/05 13:44:28]

Thomas actually seams like we forgot about popup.html, notification.js also
imported into popup.html, so maybe we don't need to change it yet.

 var require = backgroundPage.require;
 
 var Utils = require("utils").Utils;
 var Notification = require("notification").Notification;
 
 function getDocLinks(notification)
 {
   if (!notification.links)
     return [];
 
@@ skipping 49 matching lines @@
 
   messageElement.addEventListener("click", function(event)
   {
     var link = event.target;
     while (link && link !== messageElement && link.localName !== "a")
       link = link.parentNode;
     if (!link)
       return;
     event.preventDefault();
     event.stopPropagation();
-    window.open(link.href);

[Thomas Greiner, 2014/03/05 13:24:47]

You can just use chrome.tabs.create for that.

[saroyanm, 2014/03/05 13:44:28]

Again, connected to the comment for ext.backgroundPage.getWindow(), seams like
this file will be used also by safari.

+    ext.windows.getLastFocused(function(win) { win.openTab(link.href); });
   });
 
   var notificationElement = document.getElementById("notification");
   notificationElement.className = notification.severity;
   notificationElement.style.display = "block";
   
   document.getElementById("close-notification").addEventListener("click", function()
   {
     notificationElement.style.display = "none";
   }, false);
 }, false);