Unified Diff: notification.js
Issue 5767063142400000:
notification fixes (Closed)
Patch Set: removed import of ext/background.js from notification.html
Created March 4, 2014, 4:19 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« notification.html ('K')
|
« notification.html ('k')
|
safari/ext/background.js » ('j')
|
safari/ext/common.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: notification.js |
| =================================================================== |
| --- a/notification.js |
| +++ b/notification.js |
| @@ -85,7 +85,7 @@ |
| return; |
| event.preventDefault(); |
| event.stopPropagation(); |
| - ext.windows.getLastFocused(function(win) { win.openTab(link.href); }); |
| + window.open(link.href); |
|
Thomas Greiner
2014/03/05 13:24:47
You can just use chrome.tabs.create for that.
saroyanm
2014/03/05 13:44:28
Again, connected to the comment for ext.background
|
| }); |
| var notificationElement = document.getElementById("notification"); |
« notification.html ('K')
|
« notification.html ('k')
|
safari/ext/background.js » ('j')
|
safari/ext/common.js » ('J')
