background.js - Issue 5767063142400000: notification fixes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: background.js

Issue 5767063142400000: notification fixes (Closed)

Patch Set: removed import of ext/background.js from notification.html Created March 4, 2014, 4:19 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: background.js

===================================================================

--- a/background.js

+++ b/background.js

@@ -347,7 +347,8 @@

var message = texts.message ? texts.message.replace(/<\/?(a|strong)>/g, "") : "";

var iconUrl = ext.getURL("icons/abp-128.png");

var hasLinks = activeNotification.links && activeNotification.links.length > 0;

- if ("browserNotifications" in ext)

+ // Chrome on Linux does not fully support chrome.notifications yet ( https://code.google.com/p/chromium/issues/detail?id=291485 )

+ if (require("info").platform == "chromium" && "notifications" in chrome && navigator.platform.indexOf("Linux") == -1)

{

var opts = {

type: "basic",

@@ -362,7 +363,7 @@

while (match = regex.exec(plainMessage))

opts.buttons.push({title: match[1]});

- var notification = ext.browserNotifications;

+ var notification = chrome.notifications;

notification.create("", opts, function() {});

notification.onClosed.addListener(prepareNotificationIconAndPopup);

notification.onButtonClicked.addListener(notificationButtonClick);

« no previous file with comments | « no previous file | chrome/ext/background.js » ('j') | notification.html » ('J')