Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5768064935133184: Issue 2021 - Replaced FileSystem API with chrome.storage.local (Closed)

Created:
Feb. 26, 2015, 12:11 p.m. by Sebastian Noack
Modified:
April 20, 2015, 3:22 p.m.
Reviewers:
kzar, Wladimir Palant
CC:
Felix Dahlke
Visibility:
Public.

Description

Issue 2021 - Replaced FileSystem API with chrome.storage.local

Patch Set 1 #

Patch Set 2 : Rebased #

Total comments: 7

Patch Set 3 : Rebased #

Patch Set 4 : Rebased #

Patch Set 5 : Rebased #

Patch Set 6 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -321 lines) Patch
M chrome/ext/background.js View 1 2 3 1 chunk +49 lines, -0 lines 0 comments Download
R lib/filesystem/io.js View 1 chunk +0 lines, -185 lines 0 comments Download
A lib/io.js View 1 chunk +158 lines, -0 lines 0 comments Download
R lib/storage/io.js View 1 chunk +0 lines, -129 lines 0 comments Download
M metadata.chrome View 1 1 chunk +0 lines, -4 lines 0 comments Download
M metadata.common View 2 chunks +1 line, -1 line 0 comments Download
M metadata.safari View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M safari/ext/background.js View 1 2 3 4 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 8
Sebastian Noack
Feb. 26, 2015, 12:53 p.m. (2015-02-26 12:53:23 UTC) #1
kzar
http://codereview.adblockplus.org/5768064935133184/diff/5741031244955648/lib/io.js File lib/io.js (right): http://codereview.adblockplus.org/5768064935133184/diff/5741031244955648/lib/io.js#newcode29 lib/io.js:29: ext.storage.get([key], function(items) I guess they key here shouldn't be ...
March 9, 2015, 4:16 p.m. (2015-03-09 16:16:07 UTC) #2
Sebastian Noack
http://codereview.adblockplus.org/5768064935133184/diff/5741031244955648/lib/io.js File lib/io.js (right): http://codereview.adblockplus.org/5768064935133184/diff/5741031244955648/lib/io.js#newcode29 lib/io.js:29: ext.storage.get([key], function(items) On 2015/03/09 16:16:07, kzar wrote: > I ...
March 9, 2015, 4:24 p.m. (2015-03-09 16:24:43 UTC) #3
kzar
http://codereview.adblockplus.org/5768064935133184/diff/5741031244955648/lib/io.js File lib/io.js (right): http://codereview.adblockplus.org/5768064935133184/diff/5741031244955648/lib/io.js#newcode29 lib/io.js:29: ext.storage.get([key], function(items) On 2015/03/09 16:24:43, Sebastian Noack wrote: > ...
March 9, 2015, 4:35 p.m. (2015-03-09 16:35:34 UTC) #4
Sebastian Noack
http://codereview.adblockplus.org/5768064935133184/diff/5741031244955648/lib/io.js File lib/io.js (right): http://codereview.adblockplus.org/5768064935133184/diff/5741031244955648/lib/io.js#newcode138 lib/io.js:138: // Migrate files for users updating from old versions. ...
March 9, 2015, 4:43 p.m. (2015-03-09 16:43:17 UTC) #5
kzar
A lot of the migration code is pretty ugly but at least it's temporary I ...
March 9, 2015, 4:53 p.m. (2015-03-09 16:53:33 UTC) #6
Sebastian Noack
April 8, 2015, 3:08 p.m. (2015-04-08 15:08:19 UTC) #7
Wladimir Palant
April 20, 2015, 12:09 p.m. (2015-04-20 12:09:07 UTC) #8
LGTM

Powered by Google App Engine
This is Rietveld