Fix named pipe security on Windows 7

src/shared/Utils.cpp

 #include <memory>
 #include <stdexcept>
 #include <vector>
 
 #include <Windows.h>
 #include <ShlObj.h>
 
 #include "Utils.h"
 
 namespace
 {
   // See http://blogs.msdn.com/b/oldnewthing/archive/2004/10/25/247180.aspx
   EXTERN_C IMAGE_DOS_HEADER __ImageBase;
 
   std::wstring appDataPath;
 
 }
 
+std::unique_ptr<OSVERSIONINFOEX> GetWindowsVersion()

[Felix Dahlke, 2014/07/03 13:38:07]

This seems like a refactoring, can we put it in a separate review?

[Oleksandr, 2014/07/03 13:51:49]

It's addressing comments in this review. Shall we really separate it?

On 2014/07/03 13:38:07, Felix H. Dahlke wrote:

[Felix Dahlke, 2014/07/03 13:56:33]

Which comment? To switch to std::unique_ptr? That has nothing to do with the
issue at hand here, we shouldn't mix refactorings and bug fixes.

[Oleksandr, 2014/07/03 14:00:42]

http://codereview.adblockplus.org/5792731695677440/diff/5629499534213120/src/...
and 
http://codereview.adblockplus.org/5792731695677440/diff/5629499534213120/src/...
actually
On 2014/07/03 13:56:33, Felix H. Dahlke wrote:

+{
+  std::unique_ptr<OSVERSIONINFOEX> osvi(new OSVERSIONINFOEX());
+  osvi->dwOSVersionInfoSize = sizeof(OSVERSIONINFOEX);
+  GetVersionEx(reinterpret_cast<LPOSVERSIONINFO>(osvi.get()));
+  return osvi;
+}
+
 bool IsWindowsVistaOrLater()
 {
-  OSVERSIONINFOEX osvi;
-  ZeroMemory(&osvi, sizeof(OSVERSIONINFOEX));
-  osvi.dwOSVersionInfoSize = sizeof(OSVERSIONINFOEX);
-  GetVersionEx(reinterpret_cast<LPOSVERSIONINFO>(&osvi));
-  return osvi.dwMajorVersion >= 6;
+  std::unique_ptr<OSVERSIONINFOEX> osvi = GetWindowsVersion();
+  return osvi->dwMajorVersion >= 6;
 }
 
 bool IsWindows8OrLater()
 {
-  OSVERSIONINFOEX osvi;
-  ZeroMemory(&osvi, sizeof(OSVERSIONINFOEX));
-  osvi.dwOSVersionInfoSize = sizeof(OSVERSIONINFOEX);
-  GetVersionEx(reinterpret_cast<LPOSVERSIONINFO>(&osvi));
-  return osvi.dwMajorVersion >= 6 && osvi.dwMinorVersion >= 2;
+  std::unique_ptr<OSVERSIONINFOEX> osvi = GetWindowsVersion();
+  return (osvi->dwMajorVersion == 6 && osvi->dwMinorVersion >= 2) || osvi->dwMajorVersion > 6;
 }
 
 std::string ToUtf8String(const std::wstring& str)
 {
   int length = static_cast<int>(str.size());
   if (length == 0)
     return std::string();
 
   int utf8StringLength = WideCharToMultiByte(CP_UTF8, 0, str.c_str(), length, 0, 0, 0, 0);
   if (utf8StringLength == 0)
@@ skipping 76 matching lines @@
 }
 
 void ReplaceString(std::wstring& input, const std::wstring placeholder, const std::wstring replacement)
 {
   size_t replaceStart = input.find(placeholder);
   if (replaceStart != std::string::npos)
   {
     input.replace(replaceStart, placeholder.length(), replacement);
   }
 }