Issue 1107 - Support notifications

src/JsValue.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 166 matching lines @@
   const JsContext context(jsEngine);
   SetProperty(name, v8::Number::New(val));
 }
 
 void AdblockPlus::JsValue::SetProperty(const std::string& name, const JsValuePtr& val)
 {
   const JsContext context(jsEngine);
   SetProperty(name, val->UnwrapValue());
 }
 
+void AdblockPlus::JsValue::Push(const JsValuePtr& value)
+{
+  const JsContext context(jsEngine);
+  auto jsArray = v8::Local<v8::Array>::Cast(UnwrapValue());
+  jsArray->Set(jsArray->Length(), value->UnwrapValue());

[Wladimir Palant, 2015/01/22 15:19:51]

That method is unused now. You might argue that it should be there for sake of
completeness (I doubt that as we have a way to call methods already), but it
definitely doesn't belong into this patch.

[sergei, 2015/01/22 16:15:11]

Sure, removed

+}
+
 void AdblockPlus::JsValue::SetProperty(const std::string& name, bool val)
 {
   const JsContext context(jsEngine);
   SetProperty(name, v8::Boolean::New(val));
 }
 
 std::string AdblockPlus::JsValue::GetClass() const
 {
   if (!IsObject())
     throw new std::runtime_error("Cannot get constructor of a non-object");
@@ skipping 25 matching lines @@
   const v8::TryCatch tryCatch;
   v8::Local<v8::Function> func = v8::Local<v8::Function>::Cast(UnwrapValue());
   v8::Local<v8::Value> result = func->Call(thisObj, argv.size(),
       argv.size() ? &argv.front() : 0);
 
   if (tryCatch.HasCaught())
     throw JsError(tryCatch.Exception(), tryCatch.Message());
 
   return JsValuePtr(new JsValue(jsEngine, result));
 }