README.md - Issue 5823470080360448: Set the branding via confvars.sh

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: README.md

Issue 5823470080360448: Set the branding via confvars.sh (Closed)

Patch Set: Created Jan. 26, 2015, 3:10 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 Adblock Browser	1 Adblock Browser

2 ===============	2 ===============

3	3

4 The Adblock Plus browser, based on Firefox for Android.	4 The Adblock Plus browser, based on Firefox for Android.

5	5

6 Building	6 Building

7 --------	7 --------

8	8

9 Follow Mozilla's [Building Fennec](https://wiki.mozilla.org/Mobile/Fennec/Androi d)	9 Follow Mozilla's
	René Jeschke 2015/02/18 14:52:30 Is this newline really needed here? Is this newline really needed here? Felix Dahlke 2015/02/18 15:02:28 Yeah, to stick to 80 columns, I'm usually putting Show quoted text On 2015/02/18 14:52:30, René Jeschke wrote: > Is this newline really needed here? Yeah, to stick to 80 columns, I'm usually putting long links on their own line. Haven't really found a better way yet, I'd rather not have super long lines just because of the links. Would be brilliant if we could have links at the bottom as on StackOverflow... René Jeschke 2015/02/18 15:07:26 How about: Follow Mozilla's [Building Fennec][] gu Show quoted text On 2015/02/18 15:02:28, Felix H. Dahlke wrote: > On 2015/02/18 14:52:30, René Jeschke wrote: > > Is this newline really needed here? > > Yeah, to stick to 80 columns, I'm usually putting long links on their own line. > Haven't really found a better way yet, I'd rather not have super long lines just > because of the links. Would be brilliant if we could have links at the bottom as > on StackOverflow... How about: Follow Mozilla's [Building Fennec][] guide. ... more text here [Building Fennec]: https://wiki.mozilla.org/Mobile/Fennec/Android Works on github and is markdown conform. Felix Dahlke 2015/02/18 15:14:42 Done. Wasn't aware that's possible, woohoo :D Show quoted text On 2015/02/18 15:07:26, René Jeschke wrote: > On 2015/02/18 15:02:28, Felix H. Dahlke wrote: > > On 2015/02/18 14:52:30, René Jeschke wrote: > > > Is this newline really needed here? > > > > Yeah, to stick to 80 columns, I'm usually putting long links on their own > line. > > Haven't really found a better way yet, I'd rather not have super long lines > just > > because of the links. Would be brilliant if we could have links at the bottom > as > > on StackOverflow... > > How about: > Follow Mozilla's [Building Fennec][] guide. > > ... more text here > > [Building Fennec]: https://wiki.mozilla.org/Mobile/Fennec/Android > > Works on github and is markdown conform. Done. Wasn't aware that's possible, woohoo :D
10 guide, setting up your _.mozconfig_ as follows:	10 [Building Fennec](https://wiki.mozilla.org/Mobile/Fennec/Android) guide.

11

12 ac_add_options --with-android-ndk="$ANDROID_NDK_ROOT"

13 ac_add_options --with-android-sdk="$ANDROID_HOME/platforms/android-19"

14

15 # android options

16 ac_add_options --enable-application=mobile/android

17 ac_add_options --target=arm-linux-androideabi

18

19 # branding

20 ac_add_options --with-branding=mobile/android/branding/adblockbrowser

OLD	NEW

« no previous file with comments | « no previous file | mobile/android/confvars.sh » ('j') | mobile/android/confvars.sh » ('J')