Issue 370 - Make "Block element" hide elements for added filters

include.postload.js

Index: include.postload.js
===================================================================
--- a/include.postload.js
+++ b/include.postload.js
@@ -721,10 +721,11 @@
       case "clickhide-close":
         if (currentElement && msg.remove)
         {
-          // Explicitly get rid of currentElement
-          var element = currentElement.prisoner || currentElement;
-          if (element && element.parentNode)
-            element.parentNode.removeChild(element);
+          checkCollapse(currentElement.prisoner || currentElement);

[kzar, 2015/03/04 13:09:03]

IMHO there should be a comment here to mention we're hiding the right clicked
upon element if a blocking rule now matches it.

+
+          var selectors = msg.selectors;

[kzar, 2015/03/04 11:04:02]

Shouldn't we check msg.remove is true first?

[Sebastian Noack, 2015/03/04 11:34:52]

Well, we do above. ;)

[kzar, 2015/03/04 13:09:03]

Gah, sorry!

[kzar, 2015/03/04 13:09:03]

I think there should also be a comment here to say that selectors are returned
for any new hiding rules we added and so we need to hide matched elements for
those.

[Sebastian Noack, 2015/03/04 14:02:01]

I don't think it needs to be that verbose. But the other case might need some
more explanation.

[kzar, 2015/03/04 14:04:14]

Looks great.

+          if (selectors.length > 0)
+            hideElements(selectors);
         }
         clickHide_deactivate();
         break;