Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(222)

Issue 5852223410012160: Issue 1755 - Create overlays with correct positioning and z-index, considering all ancestors (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 8 months ago by Sebastian Noack
Modified:
4 years, 8 months ago
Reviewers:
kzar
CC:
Wladimir Palant
Visibility:
Public.

Description

Issue 1755 - Create overlays with correct positioning and z-index, considering all ancestors

Patch Set 1 : #

Total comments: 6

Patch Set 2 : Rebased and addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -11 lines) Patch
M include.postload.js View 1 1 chunk +32 lines, -11 lines 0 comments Download

Messages

Total messages: 6
Sebastian Noack
4 years, 8 months ago (2015-01-06 10:43:17 UTC) #1
kzar
http://codereview.adblockplus.org/5852223410012160/diff/5741031244955648/include.postload.js File include.postload.js (right): http://codereview.adblockplus.org/5852223410012160/diff/5741031244955648/include.postload.js#newcode276 include.postload.js:276: zIndex = Math.max(zIndex, parseInt(style.zIndex, 10)); zIndex is initially null ...
4 years, 8 months ago (2015-01-13 11:13:13 UTC) #2
Sebastian Noack
http://codereview.adblockplus.org/5852223410012160/diff/5741031244955648/include.postload.js File include.postload.js (right): http://codereview.adblockplus.org/5852223410012160/diff/5741031244955648/include.postload.js#newcode276 include.postload.js:276: zIndex = Math.max(zIndex, parseInt(style.zIndex, 10)); On 2015/01/13 11:13:13, kzar ...
4 years, 8 months ago (2015-01-13 13:20:09 UTC) #3
kzar
Assuming those extra few lines were deleted on purpose it LGTM. http://codereview.adblockplus.org/5852223410012160/diff/5741031244955648/include.postload.js File include.postload.js (right): ...
4 years, 8 months ago (2015-01-13 13:24:50 UTC) #4
Sebastian Noack
http://codereview.adblockplus.org/5852223410012160/diff/5741031244955648/include.postload.js File include.postload.js (right): http://codereview.adblockplus.org/5852223410012160/diff/5741031244955648/include.postload.js#newcode689 include.postload.js:689: default: On 2015/01/13 13:24:50, kzar wrote: > Did you ...
4 years, 8 months ago (2015-01-13 13:28:19 UTC) #5
kzar
4 years, 8 months ago (2015-01-13 13:28:56 UTC) #6
Ahh OK, LGTM then :)

On 2015/01/13 13:28:19, Sebastian Noack wrote:
>
http://codereview.adblockplus.org/5852223410012160/diff/5741031244955648/incl...
> File include.postload.js (right):
> 
>
http://codereview.adblockplus.org/5852223410012160/diff/5741031244955648/incl...
> include.postload.js:689: default:
> On 2015/01/13 13:24:50, kzar wrote:
> > Did you remove these lines on purpose?
> 
> I had to rebase. And those lines don't exist anymore upstream.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5