Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1407)

Issue 5859059588661248: Issue 2077 - Inject overlays with highest possible z-index (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by Sebastian Noack
Modified:
4 years, 3 months ago
Reviewers:
kzar
CC:
Wladimir Palant
Visibility:
Public.

Description

Issue 2077 - Inject overlays with highest possible z-index

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -15 lines) Patch
M include.postload.js View 3 chunks +1 line, -15 lines 3 comments Download

Messages

Total messages: 5
Sebastian Noack
4 years, 3 months ago (2015-04-08 13:29:05 UTC) #1
kzar
LGTM
4 years, 3 months ago (2015-04-08 14:05:52 UTC) #2
kzar
http://codereview.adblockplus.org/5859059588661248/diff/5629499534213120/include.postload.js File include.postload.js (right): http://codereview.adblockplus.org/5859059588661248/diff/5629499534213120/include.postload.js#newcode257 include.postload.js:257: overlay.style.zIndex = 0x7FFFFFFE; Hang on, shouldn't that be 0x7FFFFFFF?
4 years, 3 months ago (2015-04-08 14:12:21 UTC) #3
Sebastian Noack
http://codereview.adblockplus.org/5859059588661248/diff/5629499534213120/include.postload.js File include.postload.js (right): http://codereview.adblockplus.org/5859059588661248/diff/5629499534213120/include.postload.js#newcode257 include.postload.js:257: overlay.style.zIndex = 0x7FFFFFFE; On 2015/04/08 14:12:22, kzar wrote: > ...
4 years, 3 months ago (2015-04-08 14:32:45 UTC) #4
kzar
4 years, 3 months ago (2015-04-08 14:33:40 UTC) #5
LGTM

http://codereview.adblockplus.org/5859059588661248/diff/5629499534213120/incl...
File include.postload.js (right):

http://codereview.adblockplus.org/5859059588661248/diff/5629499534213120/incl...
include.postload.js:257: overlay.style.zIndex = 0x7FFFFFFE;
On 2015/04/08 14:32:45, Sebastian Noack wrote:
> On 2015/04/08 14:12:22, kzar wrote:
> > Hang on, shouldn't that be 0x7FFFFFFF?
> 
> No, 0x7FFFFFFF is the z-index of the dialog which is supposed to cover the
> overlays highlighting selected/matching elements. So we have to use a lower
> z-index here.

Gotya.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5