Issue 1115 - Some yahoo page not correctly shown on IE8 when ABP enabled

src/shared/Utils.h

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 #ifndef UTILS_H
 #define UTILS_H
 
 #include <algorithm>
 #include <locale>
 #include <functional>
 #include <string>
+#include <vector>
 
 #define WM_ALREADY_UP_TO_DATE WM_APP+1
 #define WM_UPDATE_CHECK_ERROR WM_APP+2
 #define WM_DOWNLOADING_UPDATE WM_APP+3
 
 //
 // Application Package Authority.
 //
 
 #define SECURITY_APP_PACKAGE_AUTHORITY              {0,0,0,0,0,15}
@@ skipping 10 matching lines @@
 //
 
 #define SECURITY_BUILTIN_PACKAGE_ANY_PACKAGE        (0x00000001L)
 
 
 bool IsWindowsVistaOrLater();
 bool IsWindows8OrLater();
 
 std::string ToUtf8String(const std::wstring& str);
 std::wstring ToUtf16String(const std::string& str);
+std::vector<std::wstring> ToUtf16Strings(const std::vector<std::string>& value);
 std::wstring GetDllDir();
 std::wstring GetAppDataPath();
 void ReplaceString(std::wstring& input, const std::wstring placeholder, const std::wstring replacement);
+
+/**
+ * Returns the beginning of the URL which includes the scheme and hierarchical
+ * part according to http://en.wikipedia.org/wiki/URI_scheme.
+ */
+std::wstring GetSchemeAndHierarchicalPart(const std::wstring& url);
+
 std::wstring GetQueryString(const std::wstring& url);
-/// Splits the string using delimiter 

[Eric, 2015/02/02 18:41:58]

Might as well use a doxygen-style comment here. 

  /**
   * Splits a string into tokens separated by a delimiter.
   * Applies a function to each token.
   */

[sergei, 2015/02/12 14:44:06]

fixed.

BTW, it's not necessary to have additional lines /** and leading */, doxygen
should perfectly work with /// as well.

[Eric, 2015/02/12 17:24:41]

Minimizing whitespace is not always a virtue. I find the /**-style doxygen
comment much easier to read. That's what you've done, though, so I'm fine.

-void SplitString(const std::wstring& value, wchar_t delimiter,
-  const std::function<bool(std::wstring::const_iterator begin, std::wstring::const_iterator end)>& tokenHandler);
-/// For each parameter in the query string the function calls parameterHandler
-/// until it returns false.

[Eric, 2015/02/02 18:41:58]

/**
 * Applies a function to each name=value pair in a query string.
 * Terminates early if the function returns false.
 */

[sergei, 2015/02/12 14:44:06]

done

-void ProcessQueryStringParameters(const std::wstring& urlQueryString,
-  const std::function<bool(const std::wstring& name, const std::wstring& value)>& parameterHandler);
 
 template<class T>
 T TrimString(T text)
 {
   // Via http://stackoverflow.com/questions/216823/whats-the-best-way-to-trim-stdstring
   T trimmed(text);
   std::function<bool(T::value_type)> isspace = std::bind(&std::isspace<T::value_type>, std::placeholders::_1, std::locale::classic());
   trimmed.erase(trimmed.begin(), std::find_if(trimmed.begin(), trimmed.end(), std::not1(isspace)));
   trimmed.erase(std::find_if(trimmed.rbegin(), trimmed.rend(), std::not1(isspace)).base(), trimmed.end());
   return trimmed;
 }
 
 #endif // UTILS_H