Issue 1115 - Some yahoo page not correctly shown on IE8 when ABP enabled

test/UtilGetQueryString.cpp

Index: test/UtilGetQueryString.cpp
diff --git a/test/UtilGetQueryString.cpp b/test/UtilGetQueryString.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..2869503c7faccd5a6957eb706916790fe9678ac0
--- /dev/null
+++ b/test/UtilGetQueryString.cpp
@@ -0,0 +1,45 @@
+/*
+ * This file is part of Adblock Plus <http://adblockplus.org/>,
+ * Copyright (C) 2006-2014 Eyeo GmbH
+ *
+ * Adblock Plus is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * Adblock Plus is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include <gtest/gtest.h>
+#include "../src/shared/Utils.h"
+
+TEST(GetQueryStringTest, SimpleUrl)
+{
+  EXPECT_EQ(L"", GetQueryString(L"schema://host/path1/path2"));
+}
+
+TEST(GetQueryStringTest, UrlWithQueryString)
+{
+  EXPECT_EQ(L"queryString", GetQueryString(L"schema://host/path1/path2?queryString"));
+}

[Eric, 2015/02/02 18:41:58]

Need a test for an empty query string

    L"schema://host/path1/path2?"

[sergei, 2015/02/12 14:44:06]

added

+
+TEST(GetQueryStringTest, UrlWithQueryStringAndHash)
+{
+  EXPECT_EQ(L"queryString=value", GetQueryString(L"schema://host/path1/path2?queryString=value#"));
+}

[Eric, 2015/02/02 18:41:58]

There are three tests with empty anchor strings. Need three more with non-empty
anchor strings.

[sergei, 2015/02/12 14:44:06]

I disagree here. According to such logic we should create the infinite number of
tests to test absolutely all cases which we cannot achieve. Now we cover all
execution paths of the tested function body, it should be enough.

[Eric, 2015/02/12 17:24:41]

No, not an infinite number of tests. Simply a few more tests here.
Unit tests should treat their units as black boxes, not white boxes. You can't
see inside a black box; you see inside a white box. Arguing that all execution
paths are exercised is contrary to this principle.

Unit tests should be written so that someone else implementing the same function
has the benefit of exhaustive testing. I've written lots of parsers in my life.
It is particularly useful for parsers to test exhaustively, for some reason.
When testing a parser, it's important to test as many variations in the grammar
as possible. In the present case, if it's possible for some element of a parsed
string to be empty, there should be unit tests when it's empty.

[sergei, 2015/02/13 15:21:56]

Added.

+
+TEST(GetQueryStringTest, UrlWithoutQuestionSign)
+{
+  EXPECT_EQ(L"", GetQueryString(L"schema://host/path1/path2#"));
+}
+
+TEST(GetQueryStringTest, UrlWithEmptyQueryStringAndWithHash)
+{
+  EXPECT_EQ(L"", GetQueryString(L"schema://host/path1/path2?#"));
+}
+