Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: installer/createsolutions.bat

Issue 5924532154007552: Issue 1149 - Fix the installer version (Closed)
Patch Set: Created Aug. 12, 2014, 1:32 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | installer/installer.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: installer/createsolutions.bat
===================================================================
--- a/installer/createsolutions.bat
+++ b/installer/createsolutions.bat
@@ -1,5 +1,13 @@
@echo off
+IF %1.==. GOTO NoVersion
pushd %~dp0
-python ..\libadblockplus\msvs_gyp_wrapper.py --depth=build\ia32 -f msvs --generator-output=build\ia32 -G msvs_version=2012 -Dtarget_arch=ia32 installer.gyp
-python ..\libadblockplus\msvs_gyp_wrapper.py --depth=build\x64 -f msvs --generator-output=build\x64 -G msvs_version=2012 -Dtarget_arch=x64 installer.gyp
+set version=%1
+python ..\libadblockplus\msvs_gyp_wrapper.py --depth=build\ia32 -f msvs --generator-output=build\ia32 -G msvs_version=2012 -Dtarget_arch=ia32 -Dversion=%version% installer.gyp
+python ..\libadblockplus\msvs_gyp_wrapper.py --depth=build\x64 -f msvs --generator-output=build\x64 -G msvs_version=2012 -Dtarget_arch=x64 -Dversion=%version% installer.gyp
popd
+GOTO end
Felix Dahlke 2014/08/12 07:49:58 Shouldn't that be "End" for consistency with "NoVe
+
+:NoVersion
+ echo Usage: createsolutions.bat VERSION
Eric 2014/08/12 02:11:13 It was quite useful for me to have a default devel
+
+:end
« no previous file with comments | « no previous file | installer/installer.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld