Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(224)

Issue 5934936779390976: 1377 - Blacklist dependencies from SCM tracking (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 12 months ago by mathias
Modified:
4 years, 11 months ago
Reviewers:
aalvz, Wladimir Palant
CC:
paco, aalvz
Visibility:
Public.

Description

https://issues.adblockplus.org/ticket/1377

Patch Set 1 #

Total comments: 29

Patch Set 2 : 1377 - Blacklist dependencies from Mercurial and Git tracking #

Total comments: 17

Patch Set 3 : 1377 - Blacklist dependencies from SCM tracking #

Total comments: 2

Patch Set 4 : 1377 - Blacklist dependencies from SCM tracking #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -0 lines) Patch
M ensure_dependencies.py View 1 2 3 5 chunks +41 lines, -0 lines 0 comments Download

Messages

Total messages: 17
mathias
4 years, 12 months ago (2014-09-23 09:13:55 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/5934936779390976/diff/5629499534213120/ensure_dependencies.py File ensure_dependencies.py (right): http://codereview.adblockplus.org/5934936779390976/diff/5629499534213120/ensure_dependencies.py#newcode72 ensure_dependencies.py:72: logging.warning("Mercurial won't ignore dependency %s by default. You should ...
4 years, 12 months ago (2014-09-23 15:04:13 UTC) #2
mathias
Instead of another patch-set, now just a set of comments because there is one issue ...
4 years, 12 months ago (2014-09-23 16:20:05 UTC) #3
Wladimir Palant
http://codereview.adblockplus.org/5934936779390976/diff/5629499534213120/ensure_dependencies.py File ensure_dependencies.py (right): http://codereview.adblockplus.org/5934936779390976/diff/5629499534213120/ensure_dependencies.py#newcode72 ensure_dependencies.py:72: logging.warning("Mercurial won't ignore dependency %s by default. You should ...
4 years, 11 months ago (2014-09-25 19:52:20 UTC) #4
mathias
http://codereview.adblockplus.org/5934936779390976/diff/5629499534213120/ensure_dependencies.py File ensure_dependencies.py (right): http://codereview.adblockplus.org/5934936779390976/diff/5629499534213120/ensure_dependencies.py#newcode72 ensure_dependencies.py:72: logging.warning("Mercurial won't ignore dependency %s by default. You should ...
4 years, 11 months ago (2014-09-26 05:06:38 UTC) #5
mathias
4 years, 11 months ago (2014-09-28 00:23:49 UTC) #6
mathias
http://codereview.adblockplus.org/5934936779390976/diff/5629499534213120/ensure_dependencies.py File ensure_dependencies.py (right): http://codereview.adblockplus.org/5934936779390976/diff/5629499534213120/ensure_dependencies.py#newcode72 ensure_dependencies.py:72: logging.warning("Mercurial won't ignore dependency %s by default. You should ...
4 years, 11 months ago (2014-09-28 00:24:24 UTC) #7
Wladimir Palant
http://codereview.adblockplus.org/5934936779390976/diff/5639274879778816/ensure_dependencies.py File ensure_dependencies.py (right): http://codereview.adblockplus.org/5934936779390976/diff/5639274879778816/ensure_dependencies.py#newcode48 ensure_dependencies.py:48: def _ignore(self, target, file_name): That should simply be a ...
4 years, 11 months ago (2014-10-07 22:30:13 UTC) #8
aalvz
comment http://codereview.adblockplus.org/5934936779390976/diff/5639274879778816/ensure_dependencies.py File ensure_dependencies.py (right): http://codereview.adblockplus.org/5934936779390976/diff/5639274879778816/ensure_dependencies.py#newcode48 ensure_dependencies.py:48: def _ignore(self, target, file_name): On 2014/10/07 22:30:14, Wladimir ...
4 years, 11 months ago (2014-10-08 13:49:17 UTC) #9
mathias
@aalvz Please do not comment "Done" on review tickets others have created. You cannot publish ...
4 years, 11 months ago (2014-10-08 16:00:04 UTC) #10
mathias
Hi Wladimir, please provide us with a bit more information for the first two issues ...
4 years, 11 months ago (2014-10-08 16:32:10 UTC) #11
Wladimir Palant
http://codereview.adblockplus.org/5934936779390976/diff/5639274879778816/ensure_dependencies.py File ensure_dependencies.py (right): http://codereview.adblockplus.org/5934936779390976/diff/5639274879778816/ensure_dependencies.py#newcode48 ensure_dependencies.py:48: def _ignore(self, target, file_name): On 2014/10/08 16:32:11, matze wrote: ...
4 years, 11 months ago (2014-10-08 16:46:49 UTC) #12
mathias
Hello Wladimir, thank you for the information. I'll publish another patch-set soon, according to your ...
4 years, 11 months ago (2014-10-08 17:37:55 UTC) #13
mathias
Modifications since last patch-set: 54f4ca0 1377 - Use relpath to ignore dependencies for mercurial c74f192 ...
4 years, 11 months ago (2014-10-08 20:04:01 UTC) #14
Wladimir Palant
http://codereview.adblockplus.org/5934936779390976/diff/5639274879778816/ensure_dependencies.py File ensure_dependencies.py (right): http://codereview.adblockplus.org/5934936779390976/diff/5639274879778816/ensure_dependencies.py#newcode48 ensure_dependencies.py:48: def _ignore(self, target, file_name): On 2014/10/08 17:37:55, matze wrote: ...
4 years, 11 months ago (2014-10-08 21:40:29 UTC) #15
mathias
Changes since patch-set #2: 54f4ca0 1377 - Use relpath to ignore dependencies for mercurial c74f192 ...
4 years, 11 months ago (2014-10-09 14:37:28 UTC) #16
Wladimir Palant
4 years, 11 months ago (2014-10-09 15:11:02 UTC) #17
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5