Unified Diff: options.html
Issue 5960041467215872:
Issue 1226 - Made checkbox labels on options page clickable (Closed)
Patch Set:
Created Sept. 1, 2014, 12:57 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: options.html |
| =================================================================== |
| --- a/options.html |
| +++ b/options.html |
| @@ -162,9 +162,9 @@ |
| <!-- Subscription entry template --> |
| <div id="subscriptionTemplate" class="subscription"> |
| <button class="i18n_filters_subscription_delete_label subscriptionRemoveButton"></button> |
| - <span class="subscriptionEnabledContainer"> |
| + <label class="subscriptionEnabledContainer"> |
| <input class="subscriptionEnabled" type="checkbox" /> <span class="i18n_filters_subscription_enabled_label"></span> |
| - </span> |
| + </label> |
| <a class="subscriptionTitle"></a> |
| <span class="subscriptionUpdate"></span> |
| </div> |
| @@ -197,7 +197,7 @@ |
| <div id="acceptableAdsContainer"> |
| <input type="checkbox" id="acceptableAds" /> |
| - <span class="i18n_filters_acceptableAds2_label"></span> |
| + <label for="acceptableAds" class="i18n_filters_acceptableAds2_label"></label> |
| <a id="acceptableAdsLink" href="#" target="_blank" class="i18n_filters_viewList_label"></a> |
| <a id="acceptableAdsDocs" href="#" target="_blank" class="i18n_filters_readMore_label"></a> |
| </div> |
| @@ -273,10 +273,10 @@ |
| <div id="tab-general"> |
| <p> |
| <div id="shouldShowBlockElementMenuContainer"> |
| - <input type="checkbox" id="shouldShowBlockElementMenu" /><span class="i18n_show_block_element_menu"></span> |
| + <input type="checkbox" id="shouldShowBlockElementMenu" /><label for="shouldShowBlockElementMenu" class="i18n_show_block_element_menu"></label> |
| </div> |
| <div id="hidePlaceholdersContainer"> |
| - <input type="checkbox" id="hidePlaceholders" /><span class="i18n_overlay_hideplaceholders_label"></span> |
| + <input type="checkbox" id="hidePlaceholders" /><label for="hidePlaceholders" class="i18n_overlay_hideplaceholders_label"></label> |
| </div> |
| </p> |
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
