Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: lib/subscriptionClasses.js

Issue 5964611362750464: Issue 2233 - Adapted array type annotations for JsDoc 3 (Closed)
Left Patch Set: Created March 30, 2015, 4:51 p.m.
Right Patch Set: Re-added removed argument name Created March 30, 2015, 10:51 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « lib/objectTabs.js ('k') | lib/utils.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2015 Eyeo GmbH 3 * Copyright (C) 2006-2015 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
116 { 116 {
117 let oldValue = this._disabled; 117 let oldValue = this._disabled;
118 this._disabled = value; 118 this._disabled = value;
119 FilterNotifier.triggerListeners("subscription.disabled", this, value, oldV alue); 119 FilterNotifier.triggerListeners("subscription.disabled", this, value, oldV alue);
120 } 120 }
121 return this._disabled; 121 return this._disabled;
122 }, 122 },
123 123
124 /** 124 /**
125 * Serializes the subscription to an array of strings for writing out on the d isk. 125 * Serializes the subscription to an array of strings for writing out on the d isk.
126 * @param {string[]} buffer to push the serialization results into 126 * @param {string[]} buffer buffer to push the serialization results into
Wladimir Palant 2015/03/30 18:58:05 Having "buffer" twice here wasn't a mistake - the
Sebastian Noack 2015/03/30 22:51:55 Oh, yeah. You're right.
127 */ 127 */
128 serialize: function(buffer) 128 serialize: function(buffer)
129 { 129 {
130 buffer.push("[Subscription]"); 130 buffer.push("[Subscription]");
131 buffer.push("url=" + this.url); 131 buffer.push("url=" + this.url);
132 buffer.push("title=" + this._title); 132 buffer.push("title=" + this._title);
133 if (this._fixedTitle) 133 if (this._fixedTitle)
134 buffer.push("fixedTitle=true"); 134 buffer.push("fixedTitle=true");
135 if (this._disabled) 135 if (this._disabled)
136 buffer.push("disabled=true"); 136 buffer.push("disabled=true");
(...skipping 451 matching lines...) Expand 10 before | Expand all | Expand 10 after
588 if (this.errors) 588 if (this.errors)
589 buffer.push("errors=" + this.errors); 589 buffer.push("errors=" + this.errors);
590 if (this.version) 590 if (this.version)
591 buffer.push("version=" + this.version); 591 buffer.push("version=" + this.version);
592 if (this.requiredVersion) 592 if (this.requiredVersion)
593 buffer.push("requiredVersion=" + this.requiredVersion); 593 buffer.push("requiredVersion=" + this.requiredVersion);
594 if (this.downloadCount) 594 if (this.downloadCount)
595 buffer.push("downloadCount=" + this.downloadCount); 595 buffer.push("downloadCount=" + this.downloadCount);
596 } 596 }
597 }; 597 };
LEFTRIGHT

Powered by Google App Engine
This is Rietveld