Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(73)

Issue 5978149049335808: Issue 1290 - Added support for un-prefixedcreateShadowRoot (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 2 months ago by Sebastian Noack
Modified:
5 years, 2 months ago
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 1290 - Added support for un-prefixed createShadowRoot

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -34 lines) Patch
M include.preload.js View 1 2 chunks +10 lines, -34 lines 0 comments Download

Messages

Total messages: 4
Sebastian Noack
5 years, 2 months ago (2014-08-29 20:25:30 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/5978149049335808/diff/5668600916475904/include.preload.js File include.preload.js (right): http://codereview.adblockplus.org/5978149049335808/diff/5668600916475904/include.preload.js#newcode130 include.preload.js:130: var shadow = document.documentElement.createShadowRoot(); I apparently missed that in ...
5 years, 2 months ago (2014-08-29 20:49:51 UTC) #2
Sebastian Noack
http://codereview.adblockplus.org/5978149049335808/diff/5668600916475904/include.preload.js File include.preload.js (right): http://codereview.adblockplus.org/5978149049335808/diff/5668600916475904/include.preload.js#newcode130 include.preload.js:130: var shadow = document.documentElement.createShadowRoot(); On 2014/08/29 20:49:51, Wladimir Palant ...
5 years, 2 months ago (2014-08-29 22:19:29 UTC) #3
Wladimir Palant
5 years, 2 months ago (2014-08-30 19:32:19 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5