Issues #1163, #1173 - refactor CPluginUserSettings

src/plugin/PluginUserSettings.h

+/*
+ * This file is part of Adblock Plus <https://adblockplus.org/>,
+ * Copyright (C) 2006-2015 Eyeo GmbH
+ *
+ * Adblock Plus is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * Adblock Plus is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
+ */
 #ifndef PLUGIN_USER_SETTINGS_H

[sergei, 2015/01/09 15:42:54]

What does it improve?

[Eric, 2015/01/09 16:25:24]

Consistency. All the other headers use #ifndef guards.

Personally, I'd rather be using both an #ifndef guard (for correctness) and
#pragma once (for efficiency). That's what the ATL headers do, for example. I
raised this issue elsewhere and got some pushback from Oleksandr.

 #define PLUGIN_USER_SETTINGS_H
 
 #include <OAIdl.h>
 
 /*
 Class is used to call methods Get,Set,Update of Settings object from JavaScript.
 When url is local page "user_mysettings.html", after document is loaded, C++ creates Settings object in page's JavaScript.
 Then var value = window.Settings.Get(par), window.Settings.Set(par, value), window.Settings.Update() can be called from JavaScript
 */
 class CPluginUserSettings: public IDispatch
 {
 public:
-  CPluginUserSettings() // = default;

[sergei, 2015/01/09 15:42:54]

If the implementation of the ctr is default and can be generated by the compiler
and there is no reason to have it (there are no other ctrs) then let's just
remove it.

[Eric, 2015/01/09 16:25:24]

OK.

This class shouldn't be copyable or movable, but VS2012 doesn't support the "=
delete" syntax, nor the "= default" one that would appear here.

-  {
-  }
-
   // IUnknown
   STDMETHOD(QueryInterface)(REFIID riid, void **ppvObj);
   ULONG __stdcall AddRef();
   ULONG __stdcall Release();
 
   // IDispatch
   STDMETHOD(GetTypeInfoCount)(UINT* pctinfo);
   STDMETHOD(GetTypeInfo)(UINT itinfo, LCID lcid, ITypeInfo** pptinfo);
   STDMETHOD(GetIDsOfNames)(REFIID riid, LPOLESTR* rgszNames, UINT cNames, LCID lcid, DISPID* rgdispid);
   STDMETHOD(Invoke)(DISPID dispidMember, REFIID riid, LCID lcid, WORD wFlags, DISPPARAMS* pDispparams, VARIANT* pVarResult,
     EXCEPINFO* pExcepinfo, UINT* pArgErr);
 };
 
 #endif