Issues #1163, #1173 - refactor CPluginUserSettings

src/plugin/PluginUserSettings.h

Index: src/plugin/PluginUserSettings.h
===================================================================
--- a/src/plugin/PluginUserSettings.h
+++ b/src/plugin/PluginUserSettings.h
@@ -1,7 +1,8 @@
+#ifndef PLUGIN_USER_SETTINGS_H
+#define PLUGIN_USER_SETTINGS_H
 #pragma once

[Oleksandr, 2014/08/17 22:52:01]

Do we really need both #pragma once and #ifndef above?

[Eric, 2014/09/29 18:45:41]

It's not needed for correctness; the #ifndef guard does that.

#once has better performance in the compiler, if what I've read online is true.
The idea is that compiler doesn't even read the rest of the file, saving a bunch
of I/O time during compilation. I'll also not that many (most?) of the Microsoft
system headers use this same implementation pattern, with both #ifndef guards
and #pragma once.

[Oleksandr, 2014/10/02 20:36:53]

I have never seen both versions used simultaniously, tbh. Nor do I understand
why would we need both still. I think it's best to just use #ifndef
On 2014/09/29 18:45:41, Eric wrote:

[Eric, 2014/10/14 22:23:50]

All four of the ATL library use this pattern, for example. atlbase.h, atlstr.h,
atltypes.h, atlcom.h
We don't need both. #pragma once is only an optimization to improve compile
times.

Nonetheless, I'll get rid of it. The code here has rotted so badly I can't get a
patch to apply. I'll be rewriting it. You'll see the code in the next iteration.

 
-#include <vector>
-#include <utility>
+#include <OAIdl.h>
 
 /*
 Class is used to call methods Get,Set,Update of Settings object from JavaScript.
@@ -11,7 +12,9 @@
 class CPluginUserSettings: public IDispatch
 {
 public:
-  CPluginUserSettings();
+  CPluginUserSettings() // = default;
+  {
+  }
 
   // IUnknown
   STDMETHOD(QueryInterface)(REFIID riid, void **ppvObj);
@@ -25,3 +28,5 @@
   STDMETHOD(Invoke)(DISPID dispidMember, REFIID riid, LCID lcid, WORD wFlags, DISPPARAMS* pDispparams, VARIANT* pVarResult,
     EXCEPINFO* pExcepinfo, UINT* pArgErr);
 };
+
+#endif