Issues #1163, #1173 - refactor CPluginUserSettings

src/plugin/PluginUserSettings.h

Index: src/plugin/PluginUserSettings.h
===================================================================
--- a/src/plugin/PluginUserSettings.h
+++ b/src/plugin/PluginUserSettings.h
@@ -1,7 +1,7 @@
-#pragma once
+#ifndef PLUGIN_USER_SETTINGS_H

[sergei, 2015/01/09 15:42:54]

What does it improve?

[Eric, 2015/01/09 16:25:24]

Consistency. All the other headers use #ifndef guards.

Personally, I'd rather be using both an #ifndef guard (for correctness) and
#pragma once (for efficiency). That's what the ATL headers do, for example. I
raised this issue elsewhere and got some pushback from Oleksandr.

+#define PLUGIN_USER_SETTINGS_H
 
-#include <vector>
-#include <utility>
+#include <OAIdl.h>
 
 /*
 Class is used to call methods Get,Set,Update of Settings object from JavaScript.
@@ -11,7 +11,9 @@
 class CPluginUserSettings: public IDispatch
 {
 public:
-  CPluginUserSettings();
+  CPluginUserSettings() // = default;

[sergei, 2015/01/09 15:42:54]

If the implementation of the ctr is default and can be generated by the compiler
and there is no reason to have it (there are no other ctrs) then let's just
remove it.

[Eric, 2015/01/09 16:25:24]

OK.

This class shouldn't be copyable or movable, but VS2012 doesn't support the "=
delete" syntax, nor the "= default" one that would appear here.

+  {
+  }
 
   // IUnknown
   STDMETHOD(QueryInterface)(REFIID riid, void **ppvObj);
@@ -25,3 +27,5 @@
   STDMETHOD(Invoke)(DISPID dispidMember, REFIID riid, LCID lcid, WORD wFlags, DISPPARAMS* pDispparams, VARIANT* pVarResult,
     EXCEPINFO* pExcepinfo, UINT* pArgErr);
 };
+
+#endif