Unified Diff: test/plugin/UserSettingsTest.cpp
Issue 5979857238360064:
Issues #1163, #1173 - refactor CPluginUserSettings (Closed)
Patch Set:
Created Jan. 4, 2015, 9 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« src/plugin/PluginUserSettings.cpp ('K')
|
« src/plugin/PluginUserSettings.cpp ('k')
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: test/plugin/UserSettingsTest.cpp |
| =================================================================== |
| --- a/test/plugin/UserSettingsTest.cpp |
| +++ b/test/plugin/UserSettingsTest.cpp |
| @@ -44,11 +44,6 @@ |
| DISPID ids[1]; |
| HRESULT h = x.GetIDsOfNames(IID_NULL, names, 1, 0, ids); |
| ASSERT_NE(S_OK, h); |
| - // The old version returns a nonstandard error code. |
| - if (h == DISP_E_MEMBERNOTFOUND) |
| - { |
| - return; |
| - } |
| EXPECT_EQ(DISP_E_UNKNOWNNAME, h); |
| } |
| } |
| @@ -69,6 +64,7 @@ |
| SingleMethodNameFound(L"GetDocumentationLink", 10); |
| SingleMethodNameFound(L"IsAcceptableAdsEnabled", 11); |
| SingleMethodNameFound(L"SetAcceptableAdsEnabled", 12); |
| + SingleMethodNameFound(L"IsUpdate", 13); |
| } |
| TEST(CPluginUserSettingsGetIDsOfNames, UndefinedMethodsMustNotBeFound) |
| @@ -95,11 +91,6 @@ |
| EXCEPINFO ex; |
| HRESULT h = x.Invoke(id, IID_NULL, 0, DISPATCH_METHOD, ¶ms, nullptr, &ex, nullptr); |
| ASSERT_NE(S_OK, h); |
| - // The old version returns a nonstandard error code. |
| - if (h == DISP_E_BADINDEX) |
| - { |
| - return; |
| - } |
| EXPECT_EQ(DISP_E_MEMBERNOTFOUND, h); |
| } |
| } |
| @@ -117,5 +108,5 @@ |
| */ |
| TEST(CPluginUserSettingsInvoke, InvalidDispatchIdShouldOverflow) |
| { |
| - InvokeInvalidDispatchId(13); |
| + InvokeInvalidDispatchId(14); |
| } |
« src/plugin/PluginUserSettings.cpp ('K')
|
« src/plugin/PluginUserSettings.cpp ('k')
|
no next file »
|
no next file with comments »
