Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(347)

Issue 5981059543990272: Issue 1820 - Fixed issue where multiple tabs were highlghited (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 1 month ago by Sebastian Noack
Modified:
5 years, 1 month ago
Reviewers:
kzar, Wladimir Palant
Visibility:
Public.

Description

Issue 1820 - Fixed issue where multiple tabs were highlghited

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M chrome/ext/background.js View 2 chunks +17 lines, -2 lines 1 comment Download

Messages

Total messages: 3
Sebastian Noack
5 years, 1 month ago (2015-01-16 12:28:38 UTC) #1
kzar
LGTM
5 years, 1 month ago (2015-01-16 15:36:10 UTC) #2
Wladimir Palant
5 years, 1 month ago (2015-01-16 15:59:17 UTC) #3
LGTM

http://codereview.adblockplus.org/5981059543990272/diff/5629499534213120/chro...
File chrome/ext/background.js (right):

http://codereview.adblockplus.org/5981059543990272/diff/5629499534213120/chro...
chrome/ext/background.js:56: tabs: [tab.index]
I wonder why they created an API that works with tab indices when everything
else expects tab IDs. Let's hope nobody ever runs into a race condition here.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5