include.postload.js - Issue 5989801094283264: Issue 1587 - Escape curly brackets for elemhide filters

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: include.postload.js

Issue 5989801094283264: Issue 1587 - Escape curly brackets for elemhide filters (Closed)

Patch Set: Call require() in IFEE instead in the setup hook Created Nov. 20, 2014, 3:47 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: include.postload.js

===================================================================

--- a/include.postload.js

+++ b/include.postload.js

@@ -28,7 +28,11 @@

{

var code = chr.charCodeAt(0);

- if (code <= 0x1F || code == 0x7F || /\d/.test(chr))

+ // Control characters and leading digits must be escaped based on

+ // their char code in CSS. Moreover, curly brackets aren't allowed

+ // in elemhide filters, and therefore must be escaped based on their

+ // char code as well.

+ if (code <= 0x1F || code == 0x7F || /[\d\{\}]/.test(chr))

return "\\" + code.toString(16) + " ";

return "\\" + chr;

@@ -36,7 +40,7 @@

function quote(value)

{

- return '"' + value.replace(/["\\\x00-\x1F\x7F]/g, escapeChar) + '"';

+ return '"' + value.replace(/["\\\{\}\x00-\x1F\x7F]/g, escapeChar) + '"';

}

function escapeCSS(s)

« no previous file with comments | « no previous file | qunit/tests/cssEscaping.js » ('j') | no next file with comments »