Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(272)

Issue 5991150368325632: Issue 616 - Add specificOnly parameter to matchesAny (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 6 months ago by kzar
Modified:
3 years, 11 months ago
CC:
Wladimir Palant
Visibility:
Public.

Description

Issue 616 - Add specificOnly parameter to matchesAny so that adblockpluschrome can enforce $generichide + $genericblock.

Patch Set 1 #

Patch Set 2 : Make specificOnly parameter for matchesAny actually work... #

Total comments: 6

Patch Set 3 : Tidied up _checkEntryMatch logic for finding specificOnly filters. #

Total comments: 1

Patch Set 4 : Rebased. #

Patch Set 5 : Rebased onto typeMask changes #

Patch Set 6 : Make use of new isGeneric filter method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M lib/matcher.js View 1 2 3 4 5 6 chunks +14 lines, -8 lines 0 comments Download

Messages

Total messages: 10
kzar
4 years, 6 months ago (2015-03-06 21:49:00 UTC) #1
kzar
Don't bother review this yet, it doesn't work. Working on a new patchset now.
4 years, 6 months ago (2015-03-11 15:36:01 UTC) #2
kzar
Patch Set 2 : Make specificOnly parameter for matchesAny actually work... OK it works now, ...
4 years, 6 months ago (2015-03-11 17:06:21 UTC) #3
Sebastian Noack
http://codereview.adblockplus.org/5991150368325632/diff/5750085036015616/lib/matcher.js File lib/matcher.js (right): http://codereview.adblockplus.org/5991150368325632/diff/5750085036015616/lib/matcher.js#newcode174 lib/matcher.js:174: if (filter.matches(location, contentType, docDomain, thirdParty, sitekey) && Since the ...
4 years, 6 months ago (2015-03-12 11:36:21 UTC) #4
kzar
Patch Set 3 : Tidied up _checkEntryMatch logic for finding specificOnly filters. http://codereview.adblockplus.org/5991150368325632/diff/5750085036015616/lib/matcher.js File lib/matcher.js ...
4 years, 6 months ago (2015-03-12 17:08:08 UTC) #5
Sebastian Noack
LGTM http://codereview.adblockplus.org/5991150368325632/diff/5718998062727168/lib/matcher.js File lib/matcher.js (left): http://codereview.adblockplus.org/5991150368325632/diff/5718998062727168/lib/matcher.js#oldcode171 lib/matcher.js:171: for (let i = 0; i < list.length; ...
4 years, 6 months ago (2015-03-12 17:40:06 UTC) #6
kzar
Patch Set 5 : Rebased onto typeMask changes
4 years, 2 months ago (2015-07-14 16:53:00 UTC) #7
kzar
Patch Set 6 : Make use of new isGeneric filter method
4 years ago (2015-08-25 17:44:21 UTC) #8
Thomas Greiner
LGTM
3 years, 12 months ago (2015-09-23 17:36:49 UTC) #9
Felix Dahlke
3 years, 11 months ago (2015-09-28 08:28:51 UTC) #10
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5