Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/plugin/PluginTabBase.cpp

Issue 5994126579335168: Noissue - Remove a dead inheritance and some dead code (Closed)
Patch Set: Remove comment Created Feb. 27, 2015, 4:47 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/plugin/PluginTabBase.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/plugin/PluginTabBase.cpp
===================================================================
--- a/src/plugin/PluginTabBase.cpp
+++ b/src/plugin/PluginTabBase.cpp
@@ -27,11 +27,6 @@
#include <dispex.h>
#include <Mshtmhst.h>
-int CPluginTabBase::s_dictionaryVersion = 0;
-int CPluginTabBase::s_settingsVersion = 1;
-int CPluginTabBase::s_filterVersion = 0;
-int CPluginTabBase::s_whitelistVersion = 0;
-
CPluginTabBase::CPluginTabBase(CPluginClass* plugin)
: m_plugin(plugin)
, m_isActivated(false)
@@ -347,17 +342,7 @@
DEBUG_THREAD("Loop iteration " + sTabLoopIteration);
DEBUG_THREAD("--------------------------------------------------------------------------------")
#endif
- if (this->m_isActivated)
- {
- bool isChanged = false;
-
- if (isChanged)
- {
- this->m_plugin->UpdateStatusBar();
- }
-
- this->m_isActivated = false;
- }
+ this->m_isActivated = false;
// --------------------------------------------------------------------
// End loop
@@ -368,9 +353,9 @@
{
// Post async plugin error
CPluginError pluginError;
- if (CPluginClient::PopFirstPluginError(pluginError))
+ if (LogQueue::PopFirstPluginError(pluginError))
{
- CPluginClient::LogPluginError(pluginError.GetErrorCode(), pluginError.GetErrorId(), pluginError.GetErrorSubid(), pluginError.GetErrorDescription(), true, pluginError.GetProcessId(), pluginError.GetThreadId());
+ LogQueue::LogPluginError(pluginError.GetErrorCode(), pluginError.GetErrorId(), pluginError.GetErrorSubid(), pluginError.GetErrorDescription(), true, pluginError.GetProcessId(), pluginError.GetThreadId());
}
// Non-hanging sleep
« no previous file with comments | « src/plugin/PluginTabBase.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld