 Issue 5994668214976512:
  Issue 662 - Job links shouldn't use anchors  (Closed)
    
  
    Issue 5994668214976512:
  Issue 662 - Job links shouldn't use anchors  (Closed) 
  | Left: | ||
| Right: | 
| OLD | NEW | 
|---|---|
| 1 title=Working at Eyeo | |
| 2 | |
| 3 {# | 1 {# | 
| 4 For each job opening you have to list the title and the name of the file under | 2 For each job opening you have to list the title and the name of the file under | 
| 5 includes/jobs/openings that contains the job description. | 3 pages/jobs that contains the job description. | 
| 6 #} | 4 #} | 
| 7 {% set openings = [ | 5 {% set openings = [ | 
| 8 ("Account Manager USA/GB", "account-manager-usa-gb"), | 6 ("Account Manager USA/GB", "account-manager-usa-gb"), | 
| 9 ("Senior JavaScript Developer", "senior-javascript-developer"), | 7 ("Senior JavaScript Developer", "senior-javascript-developer"), | 
| 10 ("Senior Web Developer", "senior-web-developer"), | 8 ("Senior Web Developer", "senior-web-developer"), | 
| 11 ("Android Developer", "android-developer"), | 9 ("Android Developer", "android-developer"), | 
| 12 ("PR Intern", "pr-intern"), | 10 ("PR Intern", "pr-intern"), | 
| 13 ("Business Development Manager", "business-development-manager"), | 11 ("Business Development Manager", "business-development-manager"), | 
| 14 ("Student Help Communications", "student-help-communications"), | 12 ("Student Help Communications", "student-help-communications"), | 
| 15 ("Data Scientist", "data-scientist"), | 13 ("Data Scientist", "data-scientist"), | 
| 16 ("Software Tester", "software-tester"), | 14 ("Software Tester", "software-tester"), | 
| 17 ] %} | 15 ] %} | 
| 18 {% set german_openings = [] %} | 16 {% set german_openings = [] %} | 
| 19 | 17 | 
| 20 <script src="/js/jquery.ui.core.min.js"></script> | 18 {% set opening = openings|find(page.split("/")[-1], attr=1) %} | 
| 21 <script src="/js/jquery.ui.widget.min.js"></script> | 19 {% set title, _ = opening or (title, "") %} | 
| 22 <script src="/js/jquery.ui.tabs.min.js"></script> | |
| 23 <script> | |
| 24 jQuery(function() | |
| 25 { | |
| 26 jQuery( | |
| 27 "ul:first", jQuery("#tabs-openings").tabs( | |
| 28 { | |
| 29 activate: function(event, ui) | |
| 30 { | |
| 31 var hash = ui.newTab.find("a")[0].hash; | |
| 32 if (hash != "#jobs-overview") | |
| 33 location.hash = hash; | |
| 34 window.scrollTo(0, 0); | |
| 35 } | |
| 36 }) | |
| 37 ).addClass("ui-tabs-nav-vertical"); | |
| 38 | |
| 39 jQuery("#tabs-details").tabs(); | |
| 40 | |
| 41 jQuery(window).on("hashchange", function() | |
| 42 { | |
| 43 var hash = location.hash != "" ? location.hash : "#jobs-overview"; | |
| 44 var escapedHash = hash.replace(/\+/g, "\\+"); | |
| 45 jQuery("[href=" + escapedHash + "]").click(); | |
| 46 }); | |
| 47 | |
| 48 setTimeout(function() { window.scrollTo(0, 0); }, 0); | |
| 49 }); | |
| 50 </script> | |
| 51 | |
| 52 | 20 | 
| 53 <header class="page-title"> | 21 <header class="page-title"> | 
| 54 <h1>Working at Eyeo</h1> | 22 <h1>Working at Eyeo</h1> | 
| 55 </header> | 23 </header> | 
| 56 | 24 | 
| 57 <div id="jobs-info" class="content-block"> | 25 <div id="jobs-info" class="content-block"> | 
| 58 <div id="tabs-openings" class="columns-container one-sidebar"> | 26 <div id="tabs-openings" class="columns-container one-sidebar"> | 
| 59 <div class="column sidebar-left"> | 27 <div class="column sidebar-left"> | 
| 60 <h3 class="heading centered"><span>Current openings:</span></h3> | 28 <h3 class="heading centered"><span>Current openings:</span></h3> | 
| 61 | 29 | 
| 62 <ul> | 30 <ul class="ui-tabs-nav ui-tabs-nav-vertical"> | 
| 63 <li id="jobs-overview-tab"><a href="#jobs-overview"></a></li> | |
| 64 {% for title, file in openings %} | 31 {% for title, file in openings %} | 
| 65 <li> | 32 <li {% if file == page.split("/")[-1] %} class="ui-tabs-active" {% end if %}> | 
| 66 <a href="#{{ title|slugify }}"> | 33 {{("jobs/" + file)|linkify(class = "ui-tabs-anchor")}} | 
| 
Wladimir Palant
2015/03/22 22:06:42
Nit: We generally don't put spaces around = for na
 
saroyanm
2015/03/22 23:40:51
Thanks for reference, done
 | |
| 67 {{ title }} | 34 {{ title }} | 
| 68 {% if file in german_openings %} | 35 {% if file in german_openings %} | 
| 69 <img src="/images/flags/de.png" alt="German" width="15" height=" 10"> | 36 <img src="/images/flags/de.png" alt="German" width="15" height=" 10"> | 
| 70 {% endif %} | 37 {% endif %} | 
| 71 </a> | 38 </a> | 
| 72 </li> | 39 </li> | 
| 73 {% endfor %} | 40 {% endfor %} | 
| 74 </ul> | 41 </ul> | 
| 75 | 42 | 
| 76 <p id="hiring-badges"> | 43 <p id="hiring-badges"> | 
| 77 <img id="ihk-logo" src="/images/ihk.png" alt="IHK Ausbildungsbetrieb" wi dth="120" height="80"> | 44 <img id="ihk-logo" src="/images/ihk.png" alt="IHK Ausbildungsbetrieb" wi dth="120" height="80"> | 
| 78 <img id="fair-company-logo" src="/images/fair-company.jpg" alt="Fair Com pany" height="80"> | 45 <img id="fair-company-logo" src="/images/fair-company.jpg" alt="Fair Com pany" height="80"> | 
| 79 </p> | 46 </p> | 
| 80 | 47 | 
| 81 <p> | 48 <p> | 
| 82 <? include jobs/contact ?> | 49 <? include jobs/contact ?> | 
| 83 </p> | 50 </p> | 
| 84 </div> | 51 </div> | 
| 85 | 52 | 
| 86 <div class="column"> | 53 <div class="column"> | 
| 87 <div id="panels-openings"> | 54 <div id="panels-openings" class="ui-tabs-panel"> | 
| 88 <div id="jobs-overview"> | 55 {% if opening %} | 
| 89 <? include jobs/overview ?> | 56 <h2>{{ title }}</h2> | 
| 90 | 57 {% endif %} | 
| 91 <div id="tabs-details"> | |
| 92 <ul> | |
| 93 <li><a href="#why">Why work with us?</a></li> | |
| 94 <li><a href="#benefits">Employee benefits</a></li> | |
| 95 <li><a href="#office">Our office</a></li> | |
| 96 </ul> | |
| 97 | |
| 98 <div id="why"> | |
| 99 <? include jobs/why ?> | |
| 100 </div> | |
| 101 | |
| 102 <div id="benefits"> | |
| 103 <? include jobs/benefits ?> | |
| 104 </div> | |
| 105 | |
| 106 <div id="office"> | |
| 107 <? include jobs/office ?> | |
| 108 </div> | |
| 109 </div> | |
| 110 </div> | |
| 111 | |
| 112 {% for title, file in openings %} | |
| 113 <div id="{{ title|slugify }}"> | |
| 114 <h2>{{ title }}</h2> | |
| 115 <? include jobs/openings/{{ file }} ?> | |
| 116 <a href="mailto:jobs@eyeo.com"><button>apply now</button></a> | |
| 117 <a href="#jobs-overview"><button class="why-work-here-button">why wo rk here?</button></a> | |
| 118 </div> | |
| 119 {% endfor %} | |
| 120 </div> | |
| 121 </div> | |
| 122 </div> | |
| 123 </div> | |
| OLD | NEW |