Issue 662 - Job links shouldn't use anchors

filters/find.py

+def getattribute(obj, attribute):

[Sebastian Noack, 2015/03/23 10:45:21]

Why don't you use environment.getitem() anymore?

[saroyanm, 2015/03/23 10:59:13]

I've changed according to the last Reply here:
http://codereview.adblockplus.org/5994668214976512/diff/5050731216240640/filt...
Please let me know if you still think that we need to use environment.getitem()

[Sebastian Noack, 2015/03/23 11:19:59]

Sorry, I missed that comment. However, I don't agree with Wladimir. This method
exists to assist (custom) filters and functions. Neither is it marked as
internal, unlike other methods (starting with an underscore). It is actually
documented in the source code, however not in the online documentation, which I
can only assume to be a bug.

[Sebastian Noack, 2015/03/23 12:31:14]

For reference:

13:15:01 <snoack> mitsuhiko: Is Environment.getitem() and Environment.getattr()
supposed to be an internal API, or is it safe to be used in custom filters?
13:15:19 <mitsuhiko> it's public
13:16:39 <snoack> mitsuhiko: Any reason it's not documented (except for the
source code) then? 
13:17:44 <mitsuhiko> snoack: discouragement
13:17:49 <mitsuhiko> same as with template_class i think
13:18:15 <mitsuhiko> it's public api to support the sandbox though
13:18:58 <mitsuhiko> since filters started calling it i might just document it

[saroyanm, 2015/03/23 13:07:50]

Done.

+  try:
+    return getattr(obj, str(attribute))
+  except AttributeError:
+    return obj[attribute]
+
+def find(sequence, value, attribute=None):
+  for item in sequence:
+    if (item if attribute is None else getattribute(item, attribute)) == value:
+      return item
+  return None