filters/find.py - Issue 5994668214976512: Issue 662 - Job links shouldn't use anchors

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: filters/find.py

Issue 5994668214976512: Issue 662 - Job links shouldn't use anchors (Closed)

Left Patch Set: Created March 21, 2015, 5:21 p.m.

Right Patch Set: Created March 23, 2015, 1:04 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 from jinja2 import environmentfilter, Environment	1 from jinja2 import environmentfilter
Wladimir Palant 2015/03/22 22:06:42 Nit: Environment isn't used. Not that it really ma Nit: Environment isn't used. Not that it really matters (see my other comment).
2	2

3 @environmentfilter	3 @environmentfilter

4 def find(environment, sequence, value, attr=None):	4 def find(environment, sequence, value, attribute=None):
Wladimir Palant 2015/03/22 22:06:42 Please keep attribute as the parameter name here, Please keep attribute as the parameter name here, this would be consistent with other template filters (http://jinja.pocoo.org/docs/dev/templates/#builtin-filters). saroyanm 2015/03/22 23:40:51 Done. Show quoted text On 2015/03/22 22:06:42, Wladimir Palant wrote: > Please keep attribute as the parameter name here, this would be consistent with > other template filters > (http://jinja.pocoo.org/docs/dev/templates/#builtin-filters). Done.
5 for item in sequence:	5 for item in sequence:

6 if (item if attr is None else environment.getitem(item, attr)) == value:	6 if (item if attribute is None else environment.getitem(item, attribute)) == value:

7 return item	7 return item

8 return None	8 return None

LEFT	RIGHT