Remove ext.browserAction.show/hide

background.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2013 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 64 matching lines @@
 
 // Sets options to defaults, upgrading old options from previous versions as necessary
 function setDefaultOptions()
 {
   function defaultOptionValue(opt, val)
   {
     if(!(opt in localStorage))
       localStorage[opt] = val;
   }
 
-  defaultOptionValue("shouldShowIcon", "true");
   defaultOptionValue("shouldShowBlockElementMenu", "true");
 
   removeDeprecatedOptions();
 }
 
 // Upgrade options before we do anything else.
 setDefaultOptions();
 
 /**
  * Checks whether a page is whitelisted.
@@ skipping 31 matching lines @@
   {
     var excluded = isWhitelisted(tab.url);
     iconFilename = excluded ? "icons/abp-19-whitelisted.png" : "icons/abp-19.png";
   }
 
   tab.browserAction.setIcon(iconFilename);
   tab.browserAction.setTitle(ext.i18n.getMessage("name"));
 
   iconAnimation.registerTab(tab, iconFilename);
 
-  if (localStorage.shouldShowIcon == "false")
-    tab.browserAction.hide();
-  else
-    tab.browserAction.show();
-
   if (require("info").platform == "chromium") // TODO: Implement context menus for Safari
     // Set context menu status according to whether current tab has whitelisted domain
     if (excluded)
       chrome.contextMenus.removeAll();
     else
       showContextMenu();
 }
 
 /**
  * Old versions for Opera stored patterns.ini in the localStorage object, this
@@ skipping 309 matching lines @@
   tab.sendMessage({type: "clickhide-deactivate"});
   refreshIconAndContextMenu(tab);
 });
 
 setTimeout(function()
 {
   var notificationToShow = Notification.getNextToShow();
   if (notificationToShow)
     showNotification(notificationToShow);
 }, 3 * 60 * 1000);