Issue 1498 - Look for iptables on the system first (adblockplusandroid 1.2.1)

src/org/adblockplus/android/ProxyService.java

Index: src/org/adblockplus/android/ProxyService.java
===================================================================
--- a/src/org/adblockplus/android/ProxyService.java
+++ b/src/org/adblockplus/android/ProxyService.java
@@ -583,7 +583,12 @@
     if (!RootTools.isAccessGiven())
       throw new FileNotFoundException("No root access");
 
-    File ipt = getFileStreamPath("iptables");
+    File ipt = new File("/system/bin/iptables");

[Felix Dahlke, 2015/01/09 18:51:59]

It _seems_ like a good idea to always go for iptables on the system, if it
exists. However, I never had anything to do with the iptables business in ABP
for Android, and I'd really like your opinion here, Wladimir. Do older Android
versions also have an iptables executable, one we couldn't use?

[Wladimir Palant, 2015/01/13 14:12:33]

The concern was mostly that an unknown iptables version might have different
parameters. However, that doesn't seem to be very likely.
The question is rather: do newer Android versions? Back when this code was
introduced, iptables was occasionally installed by the hardware vendor or
rooting toolkit - but it wasn't part of the regular Android setup.

+    if (!ipt.exists())
+    {
+      Log.i(TAG, "iptables not found on the system, using embedded binary");
+      ipt = getFileStreamPath("iptables");
+    }
 
     if (!ipt.exists())
     {