Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: src/plugin/PluginClientBase.h

Issue 6012307226230784: Issue #1234 - std::wstring version of UnescapeUrl (Closed)
Patch Set: Created Oct. 1, 2014, 6:52 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/plugin/PluginClientBase.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #ifndef _PLUGIN_CLIENT_BASE_H_ 1 #ifndef _PLUGIN_CLIENT_BASE_H_
2 #define _PLUGIN_CLIENT_BASE_H_ 2 #define _PLUGIN_CLIENT_BASE_H_
3 3
4 4
5 #include "PluginTypedef.h" 5 #include "PluginTypedef.h"
6 6
7 7
8 class CPluginClientFactory; 8 class CPluginClientFactory;
9 9
10 10
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 static void SetLocalization(); 68 static void SetLocalization();
69 69
70 static CString& UnescapeUrl(CString& url); 70 static CString& UnescapeUrl(CString& url);
71 71
72 static void LogPluginError(DWORD errorCode, int errorId, int errorSubid, const CString& description="", bool isAsync=false, DWORD dwProcessId=0, DWORD dwThrea dId=0); 72 static void LogPluginError(DWORD errorCode, int errorId, int errorSubid, const CString& description="", bool isAsync=false, DWORD dwProcessId=0, DWORD dwThrea dId=0);
73 73
74 static void PostPluginError(int errorId, int errorSubid, DWORD errorCode, cons t CString& errorDescription); 74 static void PostPluginError(int errorId, int errorSubid, DWORD errorCode, cons t CString& errorDescription);
75 static bool PopFirstPluginError(CPluginError& pluginError); 75 static bool PopFirstPluginError(CPluginError& pluginError);
76 }; 76 };
77 77
78 /**
79 * Wrapper around Microsoft API 'UrlUnescape'
80 *
81 * This function has modify-in-place semantics.
82 * This behavior matches that of the legacy version of this function declared ab ove.
83 * At present, callers of this function have no code to handle error conditions that might arise here.
84 * Because there's no error handling, therefore, this masks failures in UrlUnesc ape.
85 */
86 void UnescapeUrl(std::wstring& url);
78 87
79 #endif // _PLUGIN_CLIENT_BASE_H_ 88 #endif // _PLUGIN_CLIENT_BASE_H_
OLDNEW
« no previous file with comments | « no previous file | src/plugin/PluginClientBase.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld