Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(548)

Issue 6020195227271168: Moved initAntiAdblockNotification function from ui.js to its own file (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 2 months ago by Thomas Greiner
Modified:
6 years, 2 months ago
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

This is a continuation of the review addressing the suggested changes in the core module: http://codereview.adblockplus.org/5749582424178688/

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -71 lines) Patch
A lib/antiadblockInit.js View 1 1 chunk +77 lines, -0 lines 0 comments Download
M lib/ui.js View 1 5 chunks +20 lines, -71 lines 0 comments Download

Messages

Total messages: 4
Thomas Greiner
6 years, 2 months ago (2014-03-19 13:45:37 UTC) #1
Felix Dahlke
Sorry for not saying these things on IRC, but it just occurred to me: 1. ...
6 years, 2 months ago (2014-03-19 13:53:30 UTC) #2
Thomas Greiner
I see your points. Done and I'll also update the main review with those changes ...
6 years, 2 months ago (2014-03-19 14:14:33 UTC) #3
Felix Dahlke
6 years, 2 months ago (2014-03-19 14:19:57 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5