Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: locales/en/module-ownership.json

Issue 6021528219025408: Issue #1170 More progress migrating adblockplus.org to our CMS. (Closed)
Patch Set: Created Sept. 1, 2014, 10:45 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « locales/en/menu.json ('k') | locales/en/modules.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 {
2 "title": {
3 "message": "Module ownership"
4 },
5 "s1": {
6 "message": "We're using a module ownership system similar to <a>what Mozilla has</a>. While most <a>modules</a> are areas of our code base, some have nothin g to do with the code, but are governed in a very similar way."
7 },
8 "s2": {
9 "message": "The module owner role"
10 },
11 "s3": {
12 "message": "Module owners have functional authority and responsibility over their area. Only the respective super reviewer can overrule their decisions, but this should not be necessary in practice."
13 },
14 "s4": {
15 "message": "Responsibilities for code module owners"
16 },
17 "s5": {
18 "message": "Review and approve all changes to the module"
19 },
20 "s6": {
21 "message": "Grant or revoke commit access"
22 },
23 "s7": {
24 "message": "Maintain and improve quality"
25 },
26 "s8": {
27 "message": "Set the priority of new issues and reject them if necessary"
28 },
29 "s9": {
30 "message": "Ensure all high priority issues get tackled"
31 },
32 "s10": {
33 "message": "Responsibilities for non-code module owners"
34 },
35 "s11": {
36 "message": "Oversee all activities"
37 },
38 "s12": {
39 "message": "Plan future activities"
40 },
41 "s13": {
42 "message": "Ensure good communication with other modules as well as non-deve lopers"
43 },
44 "s14": {
45 "message": "Super reviews"
46 },
47 "s15": {
48 "message": "Each module has a designated super reviewer, who will oversee th ings at a higher level."
49 },
50 "s16": {
51 "message": "Super reviews for code modules"
52 },
53 "s17": {
54 "message": "While the module owner will review all changes, certain changes should also be reviewed by the super reviewer, in particular:"
55 },
56 "s18": {
57 "message": "API changes (both public API as well as API between modules)"
58 },
59 "s19": {
60 "message": "Major refactoring"
61 },
62 "s20": {
63 "message": "New subprojects"
64 },
65 "s21": {
66 "message": "For these types of changes, the module owner should review first and make sure that all of their comments are addressed, then request a super re view."
67 },
68 "s22": {
69 "message": "Super reviews for non-code modules"
70 },
71 "s23": {
72 "message": "There are no reviews for anything happening in non-code modules, but the super reviewers will oversee major projects and communication with othe r modules and non-developers in a similar fashion. The owner should report to th e respective super reviewer on a regular basis."
73 }
74 }
OLDNEW
« no previous file with comments | « locales/en/menu.json ('k') | locales/en/modules.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld