Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1023)

Issue 6025347820683264: Issue 1106 - Enable Acceptable Ads by default for new installs and updates from versions < 1.2 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 3 months ago by Oleksandr
Modified:
5 years, 3 months ago
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

Issue 1106 - Enable Acceptable Ads by default for new installs and updates from versions < 1.2

Patch Set 1 #

Total comments: 2

Patch Set 2 : Discriminate first run page title for install/update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -6 lines) Patch
M html/static/js/firstRun.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M html/static/js/ieFirstRun.js View 1 1 chunk +4 lines, -0 lines 0 comments Download
M locales/en.ini View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/engine/Main.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M src/plugin/AdblockPlusClient.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/plugin/AdblockPlusClient.cpp View 2 chunks +14 lines, -0 lines 0 comments Download
M src/plugin/PluginClass.cpp View 1 2 chunks +18 lines, -2 lines 0 comments Download
M src/plugin/PluginUserSettings.cpp View 1 2 chunks +10 lines, -1 line 0 comments Download
M src/shared/Communication.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4
Oleksandr
5 years, 3 months ago (2014-08-01 12:57:13 UTC) #1
Felix Dahlke
http://codereview.adblockplus.org/6025347820683264/diff/5629499534213120/src/plugin/PluginClass.cpp File src/plugin/PluginClass.cpp (right): http://codereview.adblockplus.org/6025347820683264/diff/5629499534213120/src/plugin/PluginClass.cpp#newcode861 src/plugin/PluginClass.cpp:861: CPluginClient::GetInstance()->SetPref(L"currentVersion", std::wstring(IEPLUGIN_VERSION)); I think we should also update currentVersion ...
5 years, 3 months ago (2014-08-01 13:07:57 UTC) #2
Oleksandr
5 years, 3 months ago (2014-08-01 15:12:39 UTC) #3
Felix Dahlke
5 years, 3 months ago (2014-08-01 15:54:57 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5