Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Delta Between Two Patch Sets: manifests/filtermasterserver.pp
Issue
6029451183783936
:
Add Filtermaster (Closed)
Left Patch Set:
Created Nov. 8, 2013, 8:35 a.m.
Right Patch Set: All Done
Created Nov. 14, 2013, 3:26 p.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Make style changes to the Filtermaster
Patch Set 3: Use a define for the repo download
Patch Set 4: Added all Changes, needs testing
Patch Set 5: Finishing Filtermaster and Testing
Patch Set 6: Add the Changes
Patch Set 7: Finish for rollout
Patch Set 8: Fix it
Patch Set 9: Add ssh
Patch Set 10: Fixes for ssh
Patch Set 11: Remove duplicate file
Patch Set 12: Remove file
Patch Set 13: All Done
Right:
Patch Set 1: None
Patch Set 2: Make style changes to the Filtermaster
Patch Set 3: Use a define for the repo download
Patch Set 4: Added all Changes, needs testing
Patch Set 5: Finishing Filtermaster and Testing
Patch Set 6: Add the Changes
Patch Set 7: Finish for rollout
Patch Set 8: Fix it
Patch Set 9: Add ssh
Patch Set 10: Fixes for ssh
Patch Set 11: Remove duplicate file
Patch Set 12: Remove file
Patch Set 13: All Done
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Vagrantfile
manifests/filtermasterserver.pp
manifests/nodes.pp
manifests/vagrant.pp
modules/filtermaster/files/sitescripts
modules/filtermaster/files/update_repos.sh
modules/filtermaster/manifests/init.pp
modules/filterserver/files/known_hosts
modules/filterserver/manifests/init.pp
modules/private-stub/files/filtermaster.adblockplus.org_ssh.key
modules/private-stub/files/filtermaster.adblockplus.org_ssh.pub
modules/private-stub/files/rsync@easylist-downloads.adblockplus.org.pub
Right:
Side by side diff
|
Download
« no previous file with change/comment
|
« Vagrantfile
('k') |
manifests/nodes.pp »
('j') |
no next file with change/comment »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
LEFT
RIGHT
(no file at all)
1
node 'filtermaster1' {
2
include base, filtermaster
3
4
class {'nagios::client':
5
server_address => 'monitoring.adblockplus.org'
6
}
7
}
LEFT
RIGHT
« Vagrantfile
('k') |
manifests/nodes.pp »
('j') |
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Toggle Comments
('s')
Edit Message
Issue 6029451183783936: Add Filtermaster (Closed)
Created Nov. 8, 2013, 8:35 a.m. by christian
Modified Nov. 15, 2013, 8:05 a.m.
Reviewers: Felix Dahlke, Wladimir Palant
Base URL:
Comments: 102
This is Rietveld