modules/updateserver/files/site.conf - Issue 6041976289886208: Issue 402 - Use a redirector script for downloads, not a direct link

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: modules/updateserver/files/site.conf

Issue 6041976289886208: Issue 402 - Use a redirector script for downloads, not a direct link (Closed)

Patch Set: Created Sept. 9, 2014, 10:41 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
1 keepalive_timeout 0;	1 keepalive_timeout 0;

2 root /var/www/update;	2 root /var/www/update;

	3

	4 location /
	mathias 2014/09/15 16:15:56 Why is the explicit empty location required? Why is the explicit empty location required? Wladimir Palant 2014/09/15 16:46:47 That's a very good question. In fact, the official Show quoted text On 2014/09/15 16:15:56, matze wrote: > Why is the explicit empty location required? That's a very good question. In fact, the official documentation doesn't really say what happens if a request doesn't match any location whatsoever. https://www.linode.com/docs/websites/nginx/basic-nginx-configuration#location... is a bit more explicit but still only recommends: "Make sure each file and folder under a domain will match at least one location directive." That's exactly what I did, I didn't bother checking what happens if I leave that location directive away. Now that I actually tested this, nginx seems to always generate an implicit \|location / {}\| - so removing it here doesn't seem to have any effect. However, I think that having it here makes things more obvious. Besides, I don't like relying on undocumented behavior. What do you think? mathias 2014/09/15 17:26:05 Agreed, leave it as it is. But thank you for the c Agreed, leave it as it is. But thank you for the clarification, though ;-)
	5 {

	6 }

	7

	8 location /latest/

	9 {

	10 fastcgi_pass unix:/tmp/multiplexer-fastcgi.sock;

	11 include /etc/nginx/fastcgi_params;

	12 }

OLD	NEW