Issue 6047895316856832: Rewrite version number in the correct file during release automation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6047895316856832: Rewrite version number in the correct file during release automation (Closed)

Created:
Jan. 15, 2014, 3:04 p.m. by Sebastian Noack

Modified:
Jan. 15, 2014, 4 p.m.

Reviewers:
Felix Dahlke, Wladimir Palant

Visibility:
Public.

Description

With http://codereview.adblockplus.org/4702358030254080/ the version number for Chrome and Safari will will be inherited from metadata.common. So we have to make sure that we rewrite the version in the correct file.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Adressed comments #

Created: Jan. 15, 2014, 4 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -8 lines)			Patch
	M	releaseAutomation.py	View	1	1 chunk	+11 lines, -8 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Wladimir Palant

Jan. 15, 2014, 3:41 p.m. (2014-01-15 15:41:20 UTC) #2

LGTM with the nits fixed.

http://codereview.adblockplus.org/6047895316856832/diff/5629499534213120/rele...
File releaseAutomation.py (right):

http://codereview.adblockplus.org/6047895316856832/diff/5629499534213120/rele...
releaseAutomation.py:29: with open(packager.readMetadata(baseDir,
type).option_source("general", "version"), 'r+b') as file:
Style nit: Please keep the line length below 80 characters if feasible. Here it
would make perfect sense to assign readMetadata result to a variable first, the
readability will improve.

http://codereview.adblockplus.org/6047895316856832/diff/5629499534213120/rele...
releaseAutomation.py:31: rawMetadata = re.sub(r'^(\s*version\s*=\s*).*',
r'\g<1>%s' % version, rawMetadata, flags=re.I | re.M)
Style nit: Please split function parameters to two lines here.

Expand All Messages | Collapse All Messages