Rewrite version number in the correct file during release automation

releaseAutomation.py

 # coding: utf-8
 
 # This file is part of the Adblock Plus build tools,
 # Copyright (C) 2006-2013 Eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU General Public License for more details.
 #
 # You should have received a copy of the GNU General Public License
 # along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
 
 import os, re, codecs, subprocess, tarfile, json
 from StringIO import StringIO
 
 def run(baseDir, type, version, keyFile, downloadsRepo):
   if type == "gecko":
     import buildtools.packagerGecko as packager
   elif type == "chrome":
     import buildtools.packagerChrome as packager
 
   # Replace version number in metadata file "manually", ConfigParser will mess
   # up the order of lines.
-  handle = open(packager.getMetadataPath(baseDir, type), 'rb')
-  rawMetadata = handle.read()
-  handle.close()
-  versionRegExp = re.compile(r'^(\s*version\s*=\s*).*', re.I | re.M)
-  rawMetadata = re.sub(versionRegExp, r'\g<1>%s' % version, rawMetadata)
-  handle = open(packager.getMetadataPath(baseDir, type), 'wb')
-  handle.write(rawMetadata)
-  handle.close()
+  with open(packager.readMetadata(baseDir, type).option_source("general", "version"), 'r+b') as file:

[Wladimir Palant, 2014/01/15 15:41:21]

Style nit: Please keep the line length below 80 characters if feasible. Here it
would make perfect sense to assign readMetadata result to a variable first, the
readability will improve.

+    rawMetadata = file.read()
+    rawMetadata = re.sub(r'^(\s*version\s*=\s*).*', r'\g<1>%s' % version, rawMetadata, flags=re.I | re.M)

[Wladimir Palant, 2014/01/15 15:41:21]

Style nit: Please split function parameters to two lines here.

+
+    file.seek(0)
+    file.write(rawMetadata)
+    file.truncate()
 
   # Read extension name from locale data
   import buildtools.packagerGecko as packagerGecko
   if type == "gecko":
     locales_base = baseDir
   else:
     # This is somewhat of a hack but reading out locale import config here would be too much
     locales_base = os.path.join(baseDir, "adblockplus")
 
   locales = packagerGecko.readLocaleMetadata(locales_base, [packagerGecko.defaultLocale])
@@ skipping 44 matching lines @@
   archiveHandle.close()
   downloads.append(archivePath)
 
   # Now add the downloads and commit
   subprocess.check_call(['hg', 'add', '-R', downloadsRepo] + downloads)
   subprocess.check_call(['hg', 'commit', '-R', downloadsRepo, '-m', 'Releasing %s %s' % (extensionName, version)])
 
   # Push all changes
   subprocess.check_call(['hg', 'push', '-R', baseDir])
   subprocess.check_call(['hg', 'push', '-R', downloadsRepo])