Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1008)

Issue 6055266931965952: Issue 1273 - Worked around WebKit getter misoptimization on Safari 8 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 2 months ago by Sebastian Noack
Modified:
5 years, 2 months ago
Reviewers:
Wladimir Palant
Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed typo in comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M lib/elemHide.js View 1 chunk +1 line, -7 lines 0 comments Download
M lib/filterClasses.js View 1 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Sebastian Noack
5 years, 2 months ago (2014-08-27 09:49:03 UTC) #1
Wladimir Palant
Much less of a hack than our previous solution, thank you. http://codereview.adblockplus.org/6055266931965952/diff/5629499534213120/lib/filterClasses.js File lib/filterClasses.js (right): ...
5 years, 2 months ago (2014-08-27 12:52:55 UTC) #2
Sebastian Noack
5 years, 2 months ago (2014-08-27 13:00:13 UTC) #3
Wladimir Palant
5 years, 2 months ago (2014-08-27 13:26:51 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5