chrome/ext/common.js - Issue 6098518317989888: Fix: Notification popup is broken

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: chrome/ext/common.js

Issue 6098518317989888: Fix: Notification popup is broken (Closed)

Patch Set: Changes after Thomas notes Created Feb. 18, 2014, 10:13 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

« background.js ('K') | « background.js ('k') | metadata.chrome » ('j') | notification.html » ('J')

OLD	NEW
1 /*	1 /*

2 * This file is part of Adblock Plus <http://adblockplus.org/>,	2 * This file is part of Adblock Plus <http://adblockplus.org/>,

3 * Copyright (C) 2006-2013 Eyeo GmbH	3 * Copyright (C) 2006-2013 Eyeo GmbH

4 *	4 *

5 * Adblock Plus is free software: you can redistribute it and/or modify	5 * Adblock Plus is free software: you can redistribute it and/or modify

6 * it under the terms of the GNU General Public License version 3 as	6 * it under the terms of the GNU General Public License version 3 as

7 * published by the Free Software Foundation.	7 * published by the Free Software Foundation.

8 *	8 *

9 * Adblock Plus is distributed in the hope that it will be useful,	9 * Adblock Plus is distributed in the hope that it will be useful,

10 * but WITHOUT ANY WARRANTY; without even the implied warranty of	10 * but WITHOUT ANY WARRANTY; without even the implied warranty of

(...skipping 94 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
105 getURL: chrome.extension.getURL,	105 getURL: chrome.extension.getURL,

106 i18n: chrome.i18n	106 i18n: chrome.i18n

107 };	107 };

108	108

109 if ("runtime" in chrome && "sendMessage" in chrome.runtime)	109 if ("runtime" in chrome && "sendMessage" in chrome.runtime)

110 ext.backgroundPage.sendMessage = chrome.runtime.sendMessage;	110 ext.backgroundPage.sendMessage = chrome.runtime.sendMessage;

111 else if ("sendMessage" in chrome.extension)	111 else if ("sendMessage" in chrome.extension)

112 ext.backgroundPage.sendMessage = chrome.extension.sendMessage;	112 ext.backgroundPage.sendMessage = chrome.extension.sendMessage;

113 else	113 else

114 ext.backgroundPage.sendMessage = chrome.extension.sendRequest;	114 ext.backgroundPage.sendMessage = chrome.extension.sendRequest;

	115

	116 if ("notifications" in chrome)
	Thomas Greiner 2014/02/18 14:26:17 Add a check for the OS name because Linux support Add a check for the OS name because Linux support is not sufficient as of right now. Also add an explanation with a link to https://code.google.com/p/chromium/issues/detail?id=291485 saroyanm 2014/02/18 16:20:28 Done. Show quoted text On 2014/02/18 14:26:17, Thomas Greiner wrote: > Add a check for the OS name because Linux support is not sufficient as of right > now. Also add an explanation with a link to > https://code.google.com/p/chromium/issues/detail?id=291485 Done.
	117 ext.notifications = chrome.notifications;

115 })();	118 })();

OLD	NEW