notification.html - Issue 6098518317989888: Fix: Notification popup is broken

Felix Dahlke 2014/02/27 14:14:43 Guess I'm missing something, but what is this nece

Thomas Greiner 2014/02/27 15:10:37 This fixes notification.js which depends on ext.*

Sebastian Noack 2014/02/28 09:56:03 No, background.js must be only executed once in th

saroyanm 2014/02/28 10:56:12 Not sure why the things will be broken, actually w

Sebastian Noack 2014/02/28 12:35:03 This will run code twice, that is supposed to run

saroyanm 2014/02/28 13:47:04 Yes I agree, but it will run twice for the users w

Yes I agree, but it will run twice for the users with old browser version, and in future I think we will get rid of the createHTMLNotification. And I'm pretty sure that this method will be deprecated for safari while it's deprecated from w3c Notificaition API. http://www.w3.org/TR/notifications/

Unfortunately I've tried to test that, but didn't worked for me, so I think It's not possible, And seams like it's only accept one parameter and It's URL: http://www.chromium.org/developers/design-documents/desktop-notifications/api... I'm not sure if the desktop notification has connection with extension. Also no success by accessing background page using chrome.extension.getBackgroundPage and chrome.extension.getViews. So I don't see another way how we can access unfortunately.

Sebastian Noack 2014/02/28 14:23:49 I've just realized that webkitNotification.createH

On 2014/02/28 13:47:04, saroyanm wrote: > On 2014/02/28 12:35:03, Sebastian Noack wrote: > > On 2014/02/28 10:56:12, saroyanm wrote: > > > On 2014/02/28 09:56:03, Sebastian Noack wrote: > > > > On 2014/02/27 15:10:37, Thomas Greiner wrote: > > > > > On 2014/02/27 14:14:43, Felix H. Dahlke wrote: > > > > > > Guess I'm missing something, but what is this necessary for? > > > > > > > > > > This fixes notification.js which depends on ext.* > > > > > > > > No, background.js must be only executed once in the background page, > > otherwise > > > > things will break. Maybe you can use window.parent.ext? > > > > > > Not sure why the things will be broken, actually we are loading the HTML > page > > > only in webkitNotifications.createHTMLNotification method and it's open html > > > page in desktop notification window. > > > > This will run code twice, that is supposed to run only once, since > > ext/background.js is already loaded by the background page itself. That > already > > makes things slower and using more memory than it would need. But when code > that > > persists data runs twice, it will lead to serious issues. This is currently > more > > a problem on Safari than on Chrome, but can also quickly lead to problems on > > Chrome. > > Yes I agree, but it will run twice for the users with old browser version, and > in future I think we will get rid of the createHTMLNotification. > And I'm pretty sure that this method will be deprecated for safari while it's > deprecated from w3c Notificaition API. > http://www.w3.org/TR/notifications/ > > > > also not sure how I can use > > > window.parent.ext in this case - the Script that uses ext api is loaded in > > > desktop notification window. > > > > The idea was that it might be possible to access the window that created the > > notification (the real background page in this case), via window.parent (like > it > > works inside frames). So you could just put "var ext = window.parent.ext;" at > > the top of notification.js, and remove the includes for ext/common.js and > > ext/background.js from notification.html. However I don't know if that works. > > But if not, there might be an other way to pass an object to the page running > > inside the notification. > > > > Unfortunately I've tried to test that, but didn't worked for me, so I think It's > not possible, > And seams like it's only accept one parameter and It's URL: > http://www.chromium.org/developers/design-documents/desktop-notifications/api... > I'm not sure if the desktop notification has connection with extension. > Also no success by accessing background page using > chrome.extension.getBackgroundPage and chrome.extension.getViews. > So I don't see another way how we can access unfortunately.

I've just realized that webkitNotification.createHTMLNotification doesn't exist in the latest version of Chrome on Linux, Windows and Mac OS X, and also not in the latest version of Safari. So either I missed something or notification.html is actually never used?

saroyanm 2014/02/28 14:34:25 As I've mentioned in my previous comment It's depr

On 2014/02/28 14:23:49, Sebastian Noack wrote: > On 2014/02/28 13:47:04, saroyanm wrote: > > On 2014/02/28 12:35:03, Sebastian Noack wrote: > > > On 2014/02/28 10:56:12, saroyanm wrote: > > > > On 2014/02/28 09:56:03, Sebastian Noack wrote: > > > > > On 2014/02/27 15:10:37, Thomas Greiner wrote: > > > > > > On 2014/02/27 14:14:43, Felix H. Dahlke wrote: > > > > > > > Guess I'm missing something, but what is this necessary for? > > > > > > > > > > > > This fixes notification.js which depends on ext.* > > > > > > > > > > No, background.js must be only executed once in the background page, > > > otherwise > > > > > things will break. Maybe you can use window.parent.ext? > > > > > > > > Not sure why the things will be broken, actually we are loading the HTML > > page > > > > only in webkitNotifications.createHTMLNotification method and it's open > html > > > > page in desktop notification window. > > > > > > This will run code twice, that is supposed to run only once, since > > > ext/background.js is already loaded by the background page itself. That > > already > > > makes things slower and using more memory than it would need. But when code > > that > > > persists data runs twice, it will lead to serious issues. This is currently > > more > > > a problem on Safari than on Chrome, but can also quickly lead to problems on > > > Chrome. > > > > Yes I agree, but it will run twice for the users with old browser version, and > > in future I think we will get rid of the createHTMLNotification. > > And I'm pretty sure that this method will be deprecated for safari while it's > > deprecated from w3c Notificaition API. > > http://www.w3.org/TR/notifications/ > > > > > > also not sure how I can use > > > > window.parent.ext in this case - the Script that uses ext api is loaded in > > > > desktop notification window. > > > > > > The idea was that it might be possible to access the window that created the > > > notification (the real background page in this case), via window.parent > (like > > it > > > works inside frames). So you could just put "var ext = window.parent.ext;" > at > > > the top of notification.js, and remove the includes for ext/common.js and > > > ext/background.js from notification.html. However I don't know if that > works. > > > But if not, there might be an other way to pass an object to the page > running > > > inside the notification. > > > > > > > Unfortunately I've tried to test that, but didn't worked for me, so I think > It's > > not possible, > > And seams like it's only accept one parameter and It's URL: > > > http://www.chromium.org/developers/design-documents/desktop-notifications/api... > > I'm not sure if the desktop notification has connection with extension. > > Also no success by accessing background page using > > chrome.extension.getBackgroundPage and chrome.extension.getViews. > > So I don't see another way how we can access unfortunately. > > I've just realized that webkitNotification.createHTMLNotification doesn't exist > in the latest version of Chrome on Linux, Windows and Mac OS X, and also not in > the latest version of Safari. So either I missed something or notification.html > is actually never used?

As I've mentioned in my previous comment It's deprecated Method but it's still used for old versions of browsers, I'm not sure from which version exactly it was removed but I'v tested it with version 26 Chrome And it's still there I can not get the newer version of chrome because of the Chrome policy that standalone versions are stopped to appear in sites with trusted source, so I can't tell from which exactly version it was removed. So you are right, for most of people It's not available.

Sebastian Noack 2014/02/28 16:59:22 I'm very much in the favor of getting rid of that

On 2014/02/28 14:34:25, saroyanm wrote: > On 2014/02/28 14:23:49, Sebastian Noack wrote: > > On 2014/02/28 13:47:04, saroyanm wrote: > > > On 2014/02/28 12:35:03, Sebastian Noack wrote: > > > > On 2014/02/28 10:56:12, saroyanm wrote: > > > > > On 2014/02/28 09:56:03, Sebastian Noack wrote: > > > > > > On 2014/02/27 15:10:37, Thomas Greiner wrote: > > > > > > > On 2014/02/27 14:14:43, Felix H. Dahlke wrote: > > > > > > > > Guess I'm missing something, but what is this necessary for? > > > > > > > > > > > > > > This fixes notification.js which depends on ext.* > > > > > > > > > > > > No, background.js must be only executed once in the background page, > > > > otherwise > > > > > > things will break. Maybe you can use window.parent.ext? > > > > > > > > > > Not sure why the things will be broken, actually we are loading the HTML > > > page > > > > > only in webkitNotifications.createHTMLNotification method and it's open > > html > > > > > page in desktop notification window. > > > > > > > > This will run code twice, that is supposed to run only once, since > > > > ext/background.js is already loaded by the background page itself. That > > > already > > > > makes things slower and using more memory than it would need. But when > code > > > that > > > > persists data runs twice, it will lead to serious issues. This is > currently > > > more > > > > a problem on Safari than on Chrome, but can also quickly lead to problems > on > > > > Chrome. > > > > > > Yes I agree, but it will run twice for the users with old browser version, > and > > > in future I think we will get rid of the createHTMLNotification. > > > And I'm pretty sure that this method will be deprecated for safari while > it's > > > deprecated from w3c Notificaition API. > > > http://www.w3.org/TR/notifications/ > > > > > > > > also not sure how I can use > > > > > window.parent.ext in this case - the Script that uses ext api is loaded > in > > > > > desktop notification window. > > > > > > > > The idea was that it might be possible to access the window that created > the > > > > notification (the real background page in this case), via window.parent > > (like > > > it > > > > works inside frames). So you could just put "var ext = window.parent.ext;" > > at > > > > the top of notification.js, and remove the includes for ext/common.js and > > > > ext/background.js from notification.html. However I don't know if that > > works. > > > > But if not, there might be an other way to pass an object to the page > > running > > > > inside the notification. > > > > > > > > > > Unfortunately I've tried to test that, but didn't worked for me, so I think > > It's > > > not possible, > > > And seams like it's only accept one parameter and It's URL: > > > > > > http://www.chromium.org/developers/design-documents/desktop-notifications/api... > > > I'm not sure if the desktop notification has connection with extension. > > > Also no success by accessing background page using > > > chrome.extension.getBackgroundPage and chrome.extension.getViews. > > > So I don't see another way how we can access unfortunately. > > > > I've just realized that webkitNotification.createHTMLNotification doesn't > exist > > in the latest version of Chrome on Linux, Windows and Mac OS X, and also not > in > > the latest version of Safari. So either I missed something or > notification.html > > is actually never used? > > As I've mentioned in my previous comment It's deprecated Method but it's still > used for old versions of browsers, I'm not sure from which version exactly it > was removed but I'v tested it with version 26 Chrome And it's still there I can > not get the newer version of chrome because of the Chrome policy that standalone > versions are stopped to appear in sites with trusted source, so I can't tell > from which exactly version it was removed. > So you are right, for most of people It's not available.

I'm very much in the favor of getting rid of that code, now. It will make problems rather sooner than later. And I don't think that supporting a minor feature on an outdated browser if worse maintaining that code.

Sebastian Noack 2014/02/28 17:01:00 s/if worse/is worth/

On 2014/02/28 16:59:22, Sebastian Noack wrote: > On 2014/02/28 14:34:25, saroyanm wrote: > > On 2014/02/28 14:23:49, Sebastian Noack wrote: > > > On 2014/02/28 13:47:04, saroyanm wrote: > > > > On 2014/02/28 12:35:03, Sebastian Noack wrote: > > > > > On 2014/02/28 10:56:12, saroyanm wrote: > > > > > > On 2014/02/28 09:56:03, Sebastian Noack wrote: > > > > > > > On 2014/02/27 15:10:37, Thomas Greiner wrote: > > > > > > > > On 2014/02/27 14:14:43, Felix H. Dahlke wrote: > > > > > > > > > Guess I'm missing something, but what is this necessary for? > > > > > > > > > > > > > > > > This fixes notification.js which depends on ext.* > > > > > > > > > > > > > > No, background.js must be only executed once in the background page, > > > > > otherwise > > > > > > > things will break. Maybe you can use window.parent.ext? > > > > > > > > > > > > Not sure why the things will be broken, actually we are loading the > HTML > > > > page > > > > > > only in webkitNotifications.createHTMLNotification method and it's > open > > > html > > > > > > page in desktop notification window. > > > > > > > > > > This will run code twice, that is supposed to run only once, since > > > > > ext/background.js is already loaded by the background page itself. That > > > > already > > > > > makes things slower and using more memory than it would need. But when > > code > > > > that > > > > > persists data runs twice, it will lead to serious issues. This is > > currently > > > > more > > > > > a problem on Safari than on Chrome, but can also quickly lead to > problems > > on > > > > > Chrome. > > > > > > > > Yes I agree, but it will run twice for the users with old browser version, > > and > > > > in future I think we will get rid of the createHTMLNotification. > > > > And I'm pretty sure that this method will be deprecated for safari while > > it's > > > > deprecated from w3c Notificaition API. > > > > http://www.w3.org/TR/notifications/ > > > > > > > > > > also not sure how I can use > > > > > > window.parent.ext in this case - the Script that uses ext api is > loaded > > in > > > > > > desktop notification window. > > > > > > > > > > The idea was that it might be possible to access the window that created > > the > > > > > notification (the real background page in this case), via window.parent > > > (like > > > > it > > > > > works inside frames). So you could just put "var ext = > window.parent.ext;" > > > at > > > > > the top of notification.js, and remove the includes for ext/common.js > and > > > > > ext/background.js from notification.html. However I don't know if that > > > works. > > > > > But if not, there might be an other way to pass an object to the page > > > running > > > > > inside the notification. > > > > > > > > > > > > > Unfortunately I've tried to test that, but didn't worked for me, so I > think > > > It's > > > > not possible, > > > > And seams like it's only accept one parameter and It's URL: > > > > > > > > > > http://www.chromium.org/developers/design-documents/desktop-notifications/api... > > > > I'm not sure if the desktop notification has connection with extension. > > > > Also no success by accessing background page using > > > > chrome.extension.getBackgroundPage and chrome.extension.getViews. > > > > So I don't see another way how we can access unfortunately. > > > > > > I've just realized that webkitNotification.createHTMLNotification doesn't > > exist > > > in the latest version of Chrome on Linux, Windows and Mac OS X, and also not > > in > > > the latest version of Safari. So either I missed something or > > notification.html > > > is actually never used? > > > > As I've mentioned in my previous comment It's deprecated Method but it's still > > used for old versions of browsers, I'm not sure from which version exactly it > > was removed but I'v tested it with version 26 Chrome And it's still there I > can > > not get the newer version of chrome because of the Chrome policy that > standalone > > versions are stopped to appear in sites with trusted source, so I can't tell > > from which exactly version it was removed. > > So you are right, for most of people It's not available. > > I'm very much in the favor of getting rid of that code, now. It will make > problems rather sooner than later. And I don't think that supporting a minor > feature on an outdated browser if worse maintaining that code.

s/if worse/is worth/

saroyanm 2014/03/03 07:08:51 Sebastian I see your point and yes while It's not

On 2014/02/28 17:01:00, Sebastian Noack wrote: > On 2014/02/28 16:59:22, Sebastian Noack wrote: > > On 2014/02/28 14:34:25, saroyanm wrote: > > > On 2014/02/28 14:23:49, Sebastian Noack wrote: > > > > On 2014/02/28 13:47:04, saroyanm wrote: > > > > > On 2014/02/28 12:35:03, Sebastian Noack wrote: > > > > > > On 2014/02/28 10:56:12, saroyanm wrote: > > > > > > > On 2014/02/28 09:56:03, Sebastian Noack wrote: > > > > > > > > On 2014/02/27 15:10:37, Thomas Greiner wrote: > > > > > > > > > On 2014/02/27 14:14:43, Felix H. Dahlke wrote: > > > > > > > > > > Guess I'm missing something, but what is this necessary for? > > > > > > > > > > > > > > > > > > This fixes notification.js which depends on ext.* > > > > > > > > > > > > > > > > No, background.js must be only executed once in the background > page, > > > > > > otherwise > > > > > > > > things will break. Maybe you can use window.parent.ext? > > > > > > > > > > > > > > Not sure why the things will be broken, actually we are loading the > > HTML > > > > > page > > > > > > > only in webkitNotifications.createHTMLNotification method and it's > > open > > > > html > > > > > > > page in desktop notification window. > > > > > > > > > > > > This will run code twice, that is supposed to run only once, since > > > > > > ext/background.js is already loaded by the background page itself. > That > > > > > already > > > > > > makes things slower and using more memory than it would need. But when > > > code > > > > > that > > > > > > persists data runs twice, it will lead to serious issues. This is > > > currently > > > > > more > > > > > > a problem on Safari than on Chrome, but can also quickly lead to > > problems > > > on > > > > > > Chrome. > > > > > > > > > > Yes I agree, but it will run twice for the users with old browser > version, > > > and > > > > > in future I think we will get rid of the createHTMLNotification. > > > > > And I'm pretty sure that this method will be deprecated for safari while > > > it's > > > > > deprecated from w3c Notificaition API. > > > > > http://www.w3.org/TR/notifications/ > > > > > > > > > > > > also not sure how I can use > > > > > > > window.parent.ext in this case - the Script that uses ext api is > > loaded > > > in > > > > > > > desktop notification window. > > > > > > > > > > > > The idea was that it might be possible to access the window that > created > > > the > > > > > > notification (the real background page in this case), via > window.parent > > > > (like > > > > > it > > > > > > works inside frames). So you could just put "var ext = > > window.parent.ext;" > > > > at > > > > > > the top of notification.js, and remove the includes for ext/common.js > > and > > > > > > ext/background.js from notification.html. However I don't know if that > > > > works. > > > > > > But if not, there might be an other way to pass an object to the page > > > > running > > > > > > inside the notification. > > > > > > > > > > > > > > > > Unfortunately I've tried to test that, but didn't worked for me, so I > > think > > > > It's > > > > > not possible, > > > > > And seams like it's only accept one parameter and It's URL: > > > > > > > > > > > > > > > http://www.chromium.org/developers/design-documents/desktop-notifications/api... > > > > > I'm not sure if the desktop notification has connection with extension. > > > > > Also no success by accessing background page using > > > > > chrome.extension.getBackgroundPage and chrome.extension.getViews. > > > > > So I don't see another way how we can access unfortunately. > > > > > > > > I've just realized that webkitNotification.createHTMLNotification doesn't > > > exist > > > > in the latest version of Chrome on Linux, Windows and Mac OS X, and also > not > > > in > > > > the latest version of Safari. So either I missed something or > > > notification.html > > > > is actually never used? > > > > > > As I've mentioned in my previous comment It's deprecated Method but it's > still > > > used for old versions of browsers, I'm not sure from which version exactly > it > > > was removed but I'v tested it with version 26 Chrome And it's still there I > > can > > > not get the newer version of chrome because of the Chrome policy that > > standalone > > > versions are stopped to appear in sites with trusted source, so I can't tell > > > from which exactly version it was removed. > > > So you are right, for most of people It's not available. > > > > I'm very much in the favor of getting rid of that code, now. It will make > > problems rather sooner than later. And I don't think that supporting a minor > > feature on an outdated browser if worse maintaining that code. > > s/if worse/is worth/

Sebastian I see your point and yes while It's not available for newer version of chrome and safari, but there is a discussion where me and Thomas agreed to use createHTMLNotification to support people with old browser version: http://codereview.adblockplus.org/6098518317989888/#msg1 So would also like to know what Thomas think about this. @Thomas what you think about removing case for createHTMLNotification support for old browsers, while as far as I understood from Sebastian notes that this will be a problem for safari (loading scripts in notification.html) and it worth to use createNotification for old browser versions as well and maybe remove notification.html file from revision control while we will no more use it ?

Thomas Greiner 2014/03/04 09:28:15 We should not remove the case for createHTMLNotifi

On 2014/03/03 07:08:51, saroyanm wrote: > On 2014/02/28 17:01:00, Sebastian Noack wrote: > > On 2014/02/28 16:59:22, Sebastian Noack wrote: > > > On 2014/02/28 14:34:25, saroyanm wrote: > > > > On 2014/02/28 14:23:49, Sebastian Noack wrote: > > > > > On 2014/02/28 13:47:04, saroyanm wrote: > > > > > > On 2014/02/28 12:35:03, Sebastian Noack wrote: > > > > > > > On 2014/02/28 10:56:12, saroyanm wrote: > > > > > > > > On 2014/02/28 09:56:03, Sebastian Noack wrote: > > > > > > > > > On 2014/02/27 15:10:37, Thomas Greiner wrote: > > > > > > > > > > On 2014/02/27 14:14:43, Felix H. Dahlke wrote: > > > > > > > > > > > Guess I'm missing something, but what is this necessary for? > > > > > > > > > > > > > > > > > > > > This fixes notification.js which depends on ext.* > > > > > > > > > > > > > > > > > > No, background.js must be only executed once in the background > > page, > > > > > > > otherwise > > > > > > > > > things will break. Maybe you can use window.parent.ext? > > > > > > > > > > > > > > > > Not sure why the things will be broken, actually we are loading > the > > > HTML > > > > > > page > > > > > > > > only in webkitNotifications.createHTMLNotification method and it's > > > open > > > > > html > > > > > > > > page in desktop notification window. > > > > > > > > > > > > > > This will run code twice, that is supposed to run only once, since > > > > > > > ext/background.js is already loaded by the background page itself. > > That > > > > > > already > > > > > > > makes things slower and using more memory than it would need. But > when > > > > code > > > > > > that > > > > > > > persists data runs twice, it will lead to serious issues. This is > > > > currently > > > > > > more > > > > > > > a problem on Safari than on Chrome, but can also quickly lead to > > > problems > > > > on > > > > > > > Chrome. > > > > > > > > > > > > Yes I agree, but it will run twice for the users with old browser > > version, > > > > and > > > > > > in future I think we will get rid of the createHTMLNotification. > > > > > > And I'm pretty sure that this method will be deprecated for safari > while > > > > it's > > > > > > deprecated from w3c Notificaition API. > > > > > > http://www.w3.org/TR/notifications/ > > > > > > > > > > > > > > also not sure how I can use > > > > > > > > window.parent.ext in this case - the Script that uses ext api is > > > loaded > > > > in > > > > > > > > desktop notification window. > > > > > > > > > > > > > > The idea was that it might be possible to access the window that > > created > > > > the > > > > > > > notification (the real background page in this case), via > > window.parent > > > > > (like > > > > > > it > > > > > > > works inside frames). So you could just put "var ext = > > > window.parent.ext;" > > > > > at > > > > > > > the top of notification.js, and remove the includes for > ext/common.js > > > and > > > > > > > ext/background.js from notification.html. However I don't know if > that > > > > > works. > > > > > > > But if not, there might be an other way to pass an object to the > page > > > > > running > > > > > > > inside the notification. > > > > > > > > > > > > > > > > > > > Unfortunately I've tried to test that, but didn't worked for me, so I > > > think > > > > > It's > > > > > > not possible, > > > > > > And seams like it's only accept one parameter and It's URL: > > > > > > > > > > > > > > > > > > > > > http://www.chromium.org/developers/design-documents/desktop-notifications/api... > > > > > > I'm not sure if the desktop notification has connection with > extension. > > > > > > Also no success by accessing background page using > > > > > > chrome.extension.getBackgroundPage and chrome.extension.getViews. > > > > > > So I don't see another way how we can access unfortunately. > > > > > > > > > > I've just realized that webkitNotification.createHTMLNotification > doesn't > > > > exist > > > > > in the latest version of Chrome on Linux, Windows and Mac OS X, and also > > not > > > > in > > > > > the latest version of Safari. So either I missed something or > > > > notification.html > > > > > is actually never used? > > > > > > > > As I've mentioned in my previous comment It's deprecated Method but it's > > still > > > > used for old versions of browsers, I'm not sure from which version exactly > > it > > > > was removed but I'v tested it with version 26 Chrome And it's still there > I > > > can > > > > not get the newer version of chrome because of the Chrome policy that > > > standalone > > > > versions are stopped to appear in sites with trusted source, so I can't > tell > > > > from which exactly version it was removed. > > > > So you are right, for most of people It's not available. > > > > > > I'm very much in the favor of getting rid of that code, now. It will make > > > problems rather sooner than later. And I don't think that supporting a minor > > > feature on an outdated browser if worse maintaining that code. > > > > s/if worse/is worth/ > > Sebastian I see your point and yes while It's not available for newer version of > chrome and safari, but there is a discussion where me and Thomas agreed to use > createHTMLNotification to support people with old browser version: > http://codereview.adblockplus.org/6098518317989888/#msg1 > > So would also like to know what Thomas think about this. > @Thomas what you think about removing case for createHTMLNotification support > for old browsers, while as far as I understood from Sebastian notes that this > will be a problem for safari (loading scripts in notification.html) and it worth > to use createNotification for old browser versions as well and maybe remove > notification.html file from revision control while we will no more use it ?

We should not remove the case for createHTMLNotification because I think we should always aim for the best user experience even if not a lot of users will see it anymore. If it turns out to be impossible to implement in Safari (which I doubt since that would've come up when we ported it over from Chrome) we could think of making this case Chrome-only.

Sebastian Noack 2014/03/05 10:45:49 createHTMLNotification isn't available for any ver

Thomas Greiner 2014/03/05 11:30:51 It's still better than window.confirm and it can h

saroyanm 2014/03/05 11:33:25 chrome.notifications Are stable since chrome v28 s

Unified Diff: notification.html