Unified Diff: chrome/ext/common.js
Issue 6098518317989888:
Fix: Notification popup is broken (Closed)
Patch Set: Already there
Created Feb. 18, 2014, 5:48 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« background.js ('K')
|
« background.js ('k')
|
metadata.chrome » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: chrome/ext/common.js |
| =================================================================== |
| --- a/chrome/ext/common.js |
| +++ b/chrome/ext/common.js |
| @@ -112,4 +112,8 @@ |
| ext.backgroundPage.sendMessage = chrome.extension.sendMessage; |
| else |
| ext.backgroundPage.sendMessage = chrome.extension.sendRequest; |
| + |
| + // Chrome on Linux does not fully support chrome.notifications yet ( https://code.google.com/p/chromium/issues/detail?id=291485 ) |
|
Thomas Greiner
2014/02/19 09:25:56
Move all of the added code to ext/chrome/backgroun
saroyanm
2014/02/19 13:14:42
Done.
Thomas, can you please give me just a hint r
|
| + if ("notifications" in chrome && navigator.platform.indexOf("Linux") == -1) |
| + ext.notifications = chrome.notifications; |
| })(); |
« background.js ('K')
|
« background.js ('k')
|
metadata.chrome » ('j')
|
no next file with comments »
